GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -279,6 +279,8 @@ void _Py_Specialize_CompareOp(PyObject lhs, PyObject rhs, _Py_CODEUNIT *instr,

		/* Deallocator function for static codeobjects used in deepfreeze.py */
		void _PyStaticCode_Dealloc(PyCodeObject *co);
		/* Function to intern strings of codeobjects */
		void _PyStaticCode_InternStrings(PyCodeObject *co);

		#ifdef Py_STATS

Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Build/2022-01-19-11-08-32.bpo-46430.k403m_.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Intern strings in deep-frozen modules. Patch by Kumar Aditya.

12 changes: 12 additions & 0 deletions 12 Objects/codeobject.c

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -1924,3 +1924,15 @@ _PyStaticCode_Dealloc(PyCodeObject *co)
		co->co_weakreflist = NULL;
		}
		}

		void
		_PyStaticCode_InternStrings(PyCodeObject *co)
		{
		int res = intern_strings(co->co_names);
		assert(res == 0);
		res = intern_string_constants(co->co_consts, NULL);
		assert(res == 0);
		res = intern_strings(co->co_localsplusnames);
		assert(res == 0);
		(void)res;
		}
Comment thread kumaraditya303 marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.

1 change: 1 addition & 0 deletions 1 Tools/scripts/deepfreeze.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -279,6 +279,7 @@ def generate_code(self, name: str, code: types.CodeType) -> str:
		self.write(f".co_cellvars = {co_cellvars},")
		self.write(f".co_freevars = {co_freevars},")
		self.deallocs.append(f"_PyStaticCode_Dealloc(&{name});")
		self.patchups.append(f"_PyStaticCode_InternStrings(&{name});")
		return f"& {name}.ob_base"

		def generate_tuple(self, name: str, t: Tuple[object, ...]) -> str:
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.