GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30871: Add test.pythoninfo by vstinner · Pull Request #3075 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 11, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add Lib/test/pythoninfo.py: script collecting various informations
about Python to help debugging test failures.

https://bugs.python.org/issue30871

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 11, 2017
@vstinner
vstinner requested a review from zware August 11, 2017 15:28
@vstinner

vstinner commented Aug 11, 2017

Copy link
Copy Markdown
Member Author

@zware: Would you mind to check if I added the pythoninfo run to all ways to run Python tests on all our CIs?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 11, 2017

Copy link
Copy Markdown
Member Author

Oh, AppVeyor doesn't want to run on my PR? I'm not sure about my PCbuild/rt.bat change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware

zware commented Aug 11, 2017

Copy link
Copy Markdown
Member

If you're only going for CI runs, then it should be removed from PCbuild\rt.bat and added to Tools\buildbot\test.bat instead. If you're going for all test runs, it could be removed from make buildbottest and added to Tools\scripts\run_test.py instead.

I think my actual preference would be to add a CLI option to regrtest, and add that flag to make buildbottest and Tools\buildbot\test.bat.

Also, AppVeyor isn't running because the most recent commit only changes .travis.yml, which AppVeyor ignores.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JulienPalard
JulienPalard reviewed Aug 11, 2017
View reviewed changes
Comment thread Lib/test/pythoninfo.py Outdated

@JulienPalard JulienPalard Aug 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuples of str does not looks accepted here, the following TypeError looks more in-sync with the implementation "value type must be str, int or None". Also I'd place this kind of comment in the docstring, it's not that far and may be usefull?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Aug 16, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JulienPalard
JulienPalard reviewed Aug 11, 2017
View reviewed changes
Comment thread Lib/test/pythoninfo.py Outdated

@JulienPalard JulienPalard Aug 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/at/as/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Aug 16, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile asottile mentioned this pull request Aug 15, 2017
bpo-29854: Print readline version information when running test suite #2618
Closed
@vstinner vstinner added the skip news label Aug 16, 2017
@vstinner

vstinner commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

@zware: "If you're only going for CI runs, then it should be removed from PCbuild\rt.bat and added to Tools\buildbot\test.bat instead. If you're going for all test runs, it could be removed from make buildbottest and added to Tools\scripts\run_test.py instead. I think my actual preference would be to add a CLI option to regrtest, and add that flag to make buildbottest and Tools\buildbot\test.bat."

I don't want to pollute test output with pythoninfo. My plan is to run pythoninfo as a separated command to be able to collapse its output.

In AppVeyor and Travis CI config, I added the pythoninfo run in the build step, so it may be collapsed by default.

"Also, AppVeyor isn't running because the most recent commit only changes .travis.yml, which AppVeyor ignores."

Oh ok. I rebased my patch serie into a single commit and rebased it, so AppVeyor will run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

@zware: Oh, I forgot to mention that I plan to add a new "pythoninfo" step on buildbots once pythoninfo is added to 2.7, 3.6 and master branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware approved these changes Aug 16, 2017
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed the script itself in detail, but the CI changes LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting merge label Aug 16, 2017
@vstinner
bpo-30871: Add test.pythoninfo
dc3257a 
* Add Lib/test/pythoninfo.py: script collecting various informations
  about Python to help debugging test failures.
* regrtest: remove sys.hash_info and sys.flags from header.
* Travis CI, Appveyor: run pythoninfo before tests
@vstinner
vstinner merged commit b907abc into python:master Aug 17, 2017
@vstinner
vstinner deleted the pythinfo branch August 17, 2017 14:40
@vstinner vstinner added needs backport to 2.7 labels Aug 17, 2017
@vstinner vstinner mentioned this pull request Aug 21, 2017
[3.6] bpo-30871: Add test.pythoninfo #3174
Merged
vstinner added a commit that referenced this pull request Aug 21, 2017
@vstinner
[3.6] bpo-30871: Add test.pythoninfo (#3174)
29d007b 
* bpo-30871: Add test.pythoninfo (#3075)

* Add Lib/test/pythoninfo.py: script collecting various informations
  about Python to help debugging test failures.
* regrtest: remove sys.hash_info and sys.flags from header.
* Travis CI, Appveyor: run pythoninfo before tests
(cherry picked from commit b907abc)

* bpo-30871: pythoninfo: add expat and _decimal (#3121)

* bpo-30871: pythoninfo: add expat and _decimal

* Remove _decimal.__version__

The string is hardcoded, not really interesting.

(cherry picked from commit f6ebd83)

* bpo-30871: Add "make pythoninfo" (#3120)

(cherry picked from commit a3a01a2)

* bpo-30871: pythoninfo: more sys, os, time data (#3130)

* bpo-30871: pythoninfo: more sys, os, time data

PythonInfo now converts types other than intger to string by default.

* fix typo

(cherry picked from commit ad7eaed)

* bpo-31231: Fix pythoninfo in Travis config (#3134)

bpo-31231, bpo-30871: Replace "./python -m test.pythoninfo" with
"make pythoninfo", since macOS uses ./python.exe.
(cherry picked from commit 92b1f90)
@vstinner vstinner mentioned this pull request Aug 21, 2017
[2.7] bpo-30871: Add test.pythoninfo (#3174) #3175
Merged
vstinner added a commit that referenced this pull request Aug 22, 2017
@vstinner
bpo-30871: Add test.pythoninfo (#3174) (#3175)
cce1cb9 
* bpo-30871: Add test.pythoninfo (#3075)

* Add Lib/test/pythoninfo.py: script collecting various informations
  about Python to help debugging test failures.
* regrtest: remove sys.hash_info and sys.flags from header.
* Travis CI, Appveyor: run pythoninfo before tests
(cherry picked from commit b907abc)

* bpo-30871: pythoninfo: add expat and _decimal (#3121)

* bpo-30871: pythoninfo: add expat and _decimal

* Remove _decimal.__version__

The string is hardcoded, not really interesting.

(cherry picked from commit f6ebd83)

* bpo-30871: Add "make pythoninfo" (#3120)

(cherry picked from commit a3a01a2)

* bpo-30871: pythoninfo: more sys, os, time data (#3130)

* bpo-30871: pythoninfo: more sys, os, time data

PythonInfo now converts types other than intger to string by default.

* fix typo

(cherry picked from commit ad7eaed)

* bpo-31231: Fix pythoninfo in Travis config (#3134)

bpo-31231, bpo-30871: Replace "./python -m test.pythoninfo" with
"make pythoninfo", since macOS uses ./python.exe.
(cherry picked from commit 92b1f90)

(cherry picked from commit 29d007b)
@Mariatta Mariatta removed the awaiting merge label Aug 29, 2017
@Mariatta Mariatta removed needs backport to 2.7 labels Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard left review comments
@zware zware zware approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @zware @JulienPalard @Mariatta @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.