GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46425: Partially revert GH-30682 by jaraco · Pull Request #30799 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Jan 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 57316c5 for files pertaining to importlib.metadata and importlib.resources (rationale).

https://bugs.python.org/issue46425

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
bpo-46425: Partially revert "bpo-46425: fix direct invocation of `tes…
1e0419f 
…t_importlib` (GH-30682)"

This reverts commit 57316c5 for files pertaining to importlib.metadata and importlib.resources.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 22, 2022
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 22, 2022
@jaraco
jaraco requested a review from sobolevn January 22, 2022 19:06
@jaraco jaraco added the skip news label Jan 22, 2022
@jaraco jaraco mentioned this pull request Jan 22, 2022
bpo-46425: fix direct invocation of test_importlib #30682
Merged
@jaraco

jaraco commented Jan 22, 2022

Copy link
Copy Markdown
Member Author

I confirmed by syncing this change into the backports that the backports no longer show a diff w.r.t the previous change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn
sobolevn approved these changes Jan 22, 2022
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The only difference between yours and #30800 is that I've left a comment on the very end of each file that is not suitable to be executed directly.

Sorry for a small breakage 🙂
TIL how backporting to https://github.com/python/importlib_metadata process looks like.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco

jaraco commented Jan 22, 2022

Copy link
Copy Markdown
Member Author

In #30800, we decided to proceed with option (b), so merging this now (once tests pass). Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Jan 22, 2022

Copy link
Copy Markdown
Member

@jaraco tests most likely won't pass 🙂
See #30801
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco closed this Jan 23, 2022
@jaraco jaraco reopened this Jan 23, 2022
@jaraco
jaraco merged commit d888ff5 into main Jan 23, 2022
@jaraco
jaraco deleted the bpo-46425/restore-simple-importlib-tests branch January 23, 2022 02:38
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 23, 2022
@sobolevn sobolevn mentioned this pull request Jan 23, 2022
Add a note about direct test module invocation python/devguide#801
Merged
@sobolevn sobolevn mentioned this pull request Apr 16, 2022
Multiple test modules fail to run if invoked directly #90583
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jaraco @sobolevn @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.