GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-41682: skip `test_sendfile_close_peer_in_the_middle_of_receiving` in `test_asyncio` by sobolevn · Pull Request #30801 · python/cpython

Conversation

sobolevn commented Jan 22, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It is failing way too often:

Most of the commits above failed due to this single test.
I don't know how to fix it, but at least we can decrease the noise.

https://bugs.python.org/issue41682

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reacted with hooray emoji

AlexWaygood reacted with heart emoji

All reactions

🎉 1 reaction
❤️ 1 reaction


          bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving…

daa6df1

… in `test_asyncio`

sobolevn requested review from 1st1 and asvetlov as code owners

January 22, 2022 19:28

sobolevn added skip news tests Tests in the Lib/test dir labels

Jan 22, 2022

erlend-aasland requested a review from vstinner

January 22, 2022 21:50

erlend-aasland commented Jan 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

If I remember correctly, all failures are on Windows. Perhaps we can skip on Windows only? I generally don't feel comfortable with just skipping a flakey test; it tends to lead to the issue being forgotten and possibly hiding real bugs. OTOH, the noise level on the CI is unbearable at the moment.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update test_sendfile.py

688b13a

sobolevn mentioned this pull request

Jan 22, 2022

bpo-46425: Partially revert GH-30682 #30799

Merged

erlend-aasland approved these changes

Jan 22, 2022

View reviewed changes

bedevere-bot added the awaiting core review label

Jan 22, 2022

erlend-aasland reviewed

Jan 22, 2022

View reviewed changes

Comment thread

Lib/test/test_asyncio/test_sendfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sobolevn commented

Jan 22, 2022

View reviewed changes

Comment thread

Lib/test/test_asyncio/test_sendfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Lib/test/test_asyncio/test_sendfile.py

jaraco approved these changes

Jan 22, 2022

View reviewed changes

Comment thread

Lib/test/test_asyncio/test_sendfile.py

		@unittest.skipIf(sys.platform.startswith('sunos'),
		"Doesn't work on Solaris")
		@unittest.skipIf(sys.platform == "win32",
		"It is flaky on Windows and needs to be fixed") # TODO: bpo-41682

jaraco Jan 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I'd probably include the bug number in the skip message in case that's all the viewer sees.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco reacted with thumbs down emoji

All reactions

👎 1 reaction

vstinner Jan 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to not include it in the skip message. Otherwise, https://bugs.python.org/issue41682 will be spammed with pull requests unrelated to the change, if a CI job fails with this message. The bot which mentions PR in bpo searchs for "bpo-xxx" anyway in a PR :-(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco reacted with thumbs up emoji

All reactions

👍 1 reaction

erlend-aasland Jan 22, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 22, 2022

vstinner approved these changes

Jan 22, 2022

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would prefer to fix it, but well, since Septembre 2020, no one was available to investigate this bug, whereas this bug annoys anyone paying attention to Python CIs for 1 year and a half.

But please don't close https://bugs.python.org/issue41682 until the real issue is fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn, erlend-aasland, AlexWaygood, and jaraco reacted with thumbs up emoji

All reactions

👍 4 reactions

vstinner merged commit 1ded8ed into python:main

Jan 22, 2022

bedevere-bot removed the awaiting merge label

Jan 22, 2022

vstinner added needs backport to 3.9 labels

Jan 22, 2022

miss-islington commented Jan 22, 2022

Copy link

Copy Markdown

Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jan 22, 2022

Copy link

Copy Markdown

Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 22, 2022


          bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…

6ab7ae7

…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-bot commented Jan 22, 2022

Copy link

Copy Markdown

GH-30811 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.9 label

Jan 22, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 22, 2022


          bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…

7b40796

…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-bot removed the needs backport to 3.10 label

Jan 22, 2022

bedevere-bot commented Jan 22, 2022

Copy link

Copy Markdown

GH-30812 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn mentioned this pull request

Jan 22, 2022

bpo-46470: remove unused branch from typing._remove_dups_flatten #30780

Merged

gvanrossum commented Jan 23, 2022

Copy link

Copy Markdown

Member

Can someone please try to figure out what caused that test to fail, and why it got worse recently?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Jan 23, 2022

Copy link

Copy Markdown

Member

Can someone please try to figure out what caused that test to fail, and why it got worse recently?

I also noticed that the step started to fail more recently recently. Maybe a CI updated Windows. I saw an announcement that Azure Pipelines or GitHub Actions (oops, I don't recall anymore) is being upgrade incrementally to Windows Server 2022, for example.

About the bug itself, it has been reported in September 2020 and so far, no one was available to investigate the issue: https://bugs.python.org/issue41682

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request

Jan 23, 2022


          bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801

ba932d9

)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>

vstinner pushed a commit that referenced this pull request

Jan 23, 2022


          bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801

486b4d3

) (GH-30812)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>

Co-authored-by: Nikita Sobolev <[email protected]>

vstinner commented Jan 23, 2022

Copy link

Copy Markdown

Member

I also noticed that the step started to fail more recently recently. Maybe a CI updated Windows. I saw an announcement that Azure Pipelines or GitHub Actions (oops, I don't recall anymore) is being upgrade incrementally to Windows Server 2022, for example.

@zooba modified the config yesterday to request explicitly Windows 2022 for the Windows jobs of the Azure Pipelines: commit 70c1646.

My PR #30817 confirms that Windows Server 2022 is now used on Azure Pipelines for the Windows jobs.

So maybe the test fails more frequently or always fails on Windows Server 2022.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev mentioned this pull request

Jan 24, 2022

bpo-26552: Fixed case where failing asyncio.ensure_future did not close the coroutine #30288

Merged

erlend-aasland mentioned this pull request

Jan 24, 2022

bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving #30845

Merged

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022


          bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…

f65180b

…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>

aeros mentioned this pull request

Oct 3, 2023

[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure #85848

Closed

Reviewers

erlend-aasland

erlend-aasland approved these changes

vstinner

vstinner approved these changes

jaraco

jaraco approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sobolevn commented Jan 22, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Jan 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaraco Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

vstinner Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

erlend-aasland Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jan 22, 2022

Uh oh!

miss-islington commented Jan 22, 2022

Uh oh!

bedevere-bot commented Jan 22, 2022

Uh oh!

bedevere-bot commented Jan 22, 2022

Uh oh!

gvanrossum commented Jan 23, 2022

Uh oh!

vstinner commented Jan 23, 2022

Uh oh!

vstinner commented Jan 23, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sobolevn commented Jan 22, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Jan 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.