GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801) by miss-islington · Pull Request #30811 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev [email protected]

https://bugs.python.org/issue41682

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…
6ab7ae7 
…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners January 22, 2022 22:53
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 22, 2022
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir skip news labels Jan 22, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jan 22, 2022
bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio #30801
Merged
@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jan 22, 2022
@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Jan 22, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 22, 2022
@miss-islington

miss-islington commented Jan 23, 2022

Copy link
Copy Markdown
Contributor Author

@sobolevn and @vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit ba932d9 into python:3.9 Jan 23, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 23, 2022
@miss-islington
miss-islington deleted the backport-1ded8ed-3.9 branch January 23, 2022 00:20
@aeros aeros mentioned this pull request Oct 3, 2023
[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure #85848
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.