GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46607: Add DeprecationWarning to LegacyInterpolation by hugovk · Pull Request #30927 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jan 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

LegacyInterpolation has been deprecated in docs since its introduction in Python 3.2:

class LegacyInterpolation(Interpolation):
    """Deprecated interpolation used in old versions of ConfigParser.
    Use BasicInterpolation or ExtendedInterpolation instead."""

Let's add a DeprecationWarning for a couple of releases before removal.

https://bugs.python.org/issue46607

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 26, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 26, 2022
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 0541fd9 to 80d4f4a Compare January 26, 2022 22:00
@hugovk

This comment has been minimized.

Sign in to view
@hugovk
hugovk marked this pull request as draft January 27, 2022 09:20
@hugovk hugovk added DO-NOT-MERGE and removed awaiting review labels Jan 27, 2022
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 80d4f4a to 2c616f3 Compare February 2, 2022 07:06
@hugovk hugovk changed the title bpo-45173: Add DeprecationWarning to LegacyInterpolation bpo-46607: Add DeprecationWarning to LegacyInterpolation Feb 2, 2022
@hugovk

This comment was marked as resolved.

Sign in to view
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 2c616f3 to 850073b Compare February 2, 2022 18:45
@hugovk hugovk added awaiting review DO-NOT-MERGE and removed DO-NOT-MERGE labels Feb 2, 2022
@hugovk
hugovk marked this pull request as ready for review February 2, 2022 18:55
@hugovk hugovk removed the DO-NOT-MERGE label Feb 2, 2022
@hugovk
bpo-46607: Add DeprecationWarning for LegacyInterpolation, deprecated…
2aa86b8 
… in docs since 3.2
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation branch from 850073b to 2aa86b8 Compare February 3, 2022 14:28
@hugovk
Merge branch 'main' into issue45173-deprecate-LegacyInterpolation
25296e1
@hugovk

This comment was marked as resolved.

Sign in to view
gvanrossum
gvanrossum approved these changes Apr 2, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let’s do this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 2, 2022
gpshead
gpshead approved these changes Apr 5, 2022
View reviewed changes
@gpshead
gpshead merged commit 7528094 into python:main Apr 5, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 5, 2022
@hugovk
hugovk deleted the issue45173-deprecate-LegacyInterpolation branch April 5, 2022 16:27
@tirkarthi

tirkarthi commented Apr 12, 2022

Copy link
Copy Markdown
Member

@hugovk The PR introduces deprecation warnings in tests that need to be handled :

PYTHONWARNINGS=always ./python -Wall -m test test_configparser
0:00:00 load avg: 2.29 Run tests sequentially
0:00:00 load avg: 2.29 [1/1] test_configparser
/home/karthikeyan/stuff/python/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead.
  interpolation = configparser.LegacyInterpolation()

== Tests result: SUCCESS ==

1 test OK.

Total duration: 300 ms
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

@tirkarthi Thanks, will check it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Apr 12, 2022
gh-90765: Catch LegacyInterpolation deprecation warning #91480
Merged
@hugovk

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

Please see #91480.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @tirkarthi @gpshead @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.