GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90765: Catch LegacyInterpolation deprecation warning by hugovk · Pull Request #91480 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Apr 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow on from gh-90765, see #30927 (comment).

Before

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparser
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 5.65 Run tests sequentially
0:00:00 load avg: 5.65 [1/1] test_configparser
/Users/huvankem/github/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead.
  interpolation = configparser.LegacyInterpolation()

== Tests result: SUCCESS ==

1 test OK.

Total duration: 476 ms
Tests result: SUCCESS

After

$ PYTHONWARNINGS=always ./python.exe -Wall -m test test_configparser
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 5.67 Run tests sequentially
0:00:00 load avg: 5.67 [1/1] test_configparser

== Tests result: SUCCESS ==

1 test OK.

Total duration: 468 ms
Tests result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation2 branch from 1aefad5 to b820cd5 Compare April 12, 2022 11:11
@ghost

ghost commented Apr 12, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2022
@hugovk
pythongh-90765: Catch deprecation warning
27d64de
@hugovk hugovk changed the title bpo-46607: Catch LegacyInterpolation deprecation warning gh-90765: Catch LegacyInterpolation deprecation warning Apr 12, 2022
@hugovk
hugovk force-pushed the issue45173-deprecate-LegacyInterpolation2 branch from b820cd5 to 27d64de Compare April 12, 2022 11:12
@hugovk hugovk mentioned this pull request Apr 12, 2022
bpo-46607: Add DeprecationWarning to LegacyInterpolation #30927
Merged
@hugovk
hugovk requested a review from tirkarthi April 12, 2022 11:14
@hugovk

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

@tirkarthi Does this need a news file or skip-news label?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tirkarthi tirkarthi added skip issue skip news labels Apr 12, 2022
tirkarthi
tirkarthi approved these changes Apr 12, 2022
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hugovk .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 12, 2022
@AlexWaygood

AlexWaygood commented Apr 12, 2022

Copy link
Copy Markdown
Member

All commit authors signed the Contributor License Agreement. CLA signed

@ambv any idea why the CLA CI check is red, even though the comment here says it's green?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Apr 12, 2022

Copy link
Copy Markdown
Member Author

I have already signed the old CLA. When I first created the PR, the CLA comment was red:

image

So I clicked the link to sign the new one anyway. It turned the comment green but not the check:

image

AlexWaygood reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv closed this Apr 14, 2022
@ambv ambv reopened this Apr 14, 2022
@JelleZijlstra
JelleZijlstra merged commit 56f9844 into python:main May 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 2, 2022
@hugovk
hugovk deleted the issue45173-deprecate-LegacyInterpolation2 branch May 2, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @AlexWaygood @tirkarthi @ambv @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.