GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45162: Revert "Remove many old deprecated unittest features" by gpshead · Pull Request #30935 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Jan 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit b0a6ede.

We're deferring this change until 3.12 while upstream projects that use
the legacy assertion method names are fixed. See the issue for links
to the discussion.

https://bugs.python.org/issue45162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gpshead
Revert "bpo-45162: Remove many old deprecated unittest features (pyth…
5c43e9c
…onGH-28268)"

This reverts commit b0a6ede.

We're deferring this change until 3.12 while upstream projects that use
the legacy assertion method names are fixed.  See the issue for links
to the discussion.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 27, 2022
@gpshead
news entry
a25878d
@gpshead
gpshead requested a review from vstinner January 27, 2022 00:01
@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member

I don't understand the Docs CI failure:

PATH=./venv/bin:$PATH sphinx-build -b doctest -d build/doctrees  -q -W --keep-going -j4 -W . build/doctest 
...
make[1]: *** [Makefile:51: build] Error 1
make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Testing of doctests in the sources finished, look at the results in build/doctest/output.txt
make: *** [Makefile:131: doctest] Error 1
make: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Error: Process completed with exit code 2.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member

Ah, maybe the warning is treated as an error:

Warning: ../build/NEWS:83: WARNING: Unknown interpreted text role "module".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member

I guess that the change is related to this python-dev discussion:
https://mail.python.org/archives/list/[email protected]/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/

gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Jan 27, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-01-26-23-58-48.bpo-45162.4Jmg_j.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@gpshead @vstinner
Update Misc/NEWS.d/next/Library/2022-01-26-23-58-48.bpo-45162.4Jmg_j.rst
09b89d2
Co-authored-by: Victor Stinner <[email protected]>
@gpshead
gpshead merged commit b50322d into python:main Jan 27, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 27, 2022
@gpshead
gpshead deleted the defer-bpo45162-to-312 branch January 27, 2022 04:39
@bedevere-bot

bedevere-bot commented Jan 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 C9S 3.x has failed when building commit b50322d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/791/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (b50322d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/791/builds/4

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 21, done.        
remote: Counting objects:   4% (1/21)        
remote: Counting objects:   9% (2/21)        
remote: Counting objects:  14% (3/21)        
remote: Counting objects:  19% (4/21)        
remote: Counting objects:  23% (5/21)        
remote: Counting objects:  28% (6/21)        
remote: Counting objects:  33% (7/21)        
remote: Counting objects:  38% (8/21)        
remote: Counting objects:  42% (9/21)        
remote: Counting objects:  47% (10/21)        
remote: Counting objects:  52% (11/21)        
remote: Counting objects:  57% (12/21)        
remote: Counting objects:  61% (13/21)        
remote: Counting objects:  66% (14/21)        
remote: Counting objects:  71% (15/21)        
remote: Counting objects:  76% (16/21)        
remote: Counting objects:  80% (17/21)        
remote: Counting objects:  85% (18/21)        
remote: Counting objects:  90% (19/21)        
remote: Counting objects:  95% (20/21)        
remote: Counting objects: 100% (21/21)        
remote: Counting objects: 100% (21/21), done.        
remote: Compressing objects:  10% (1/10)        
remote: Compressing objects:  20% (2/10)        
remote: Compressing objects:  30% (3/10)        
remote: Compressing objects:  40% (4/10)        
remote: Compressing objects:  50% (5/10)        
remote: Compressing objects:  60% (6/10)        
remote: Compressing objects:  70% (7/10)        
remote: Compressing objects:  80% (8/10)        
remote: Compressing objects:  90% (9/10)        
remote: Compressing objects: 100% (10/10)        
remote: Compressing objects: 100% (10/10), done.        
remote: Total 21 (delta 11), reused 11 (delta 11), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'b50322d20337ca468f2070eedb051a16ee1eba94'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at b50322d203 [bpo-45162](https://bugs.python.org/issue45162): Revert "Remove many old deprecated unittest features" (GH-30935)
Switched to and reset branch 'main'

In file included from ../Modules/expat/xmltok.c:57:
../Modules/expat/xmltok_ns.c: In function ‘findEncoding’:
../Modules/expat/xmltok.h:276:10: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized]
  276 |   (((enc)->utf8Convert)(enc, fromP, fromLim, toP, toLim))
      |   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../Modules/expat/xmltok.h:276:10: note: by argument 5 of type ‘const char *’ to ‘XML_Convert_Result <T6d3> (const struct ENCODING *, const char * *, const char *, char * *, const char *)’
In file included from ../Modules/expat/xmltok.c:1654:
../Modules/expat/xmltok_ns.c:96:8: note: ‘buf’ declared here
   96 |   char buf[ENCODING_MAX];
      |        ^~~
In file included from ../Modules/expat/xmltok.c:57:
../Modules/expat/xmltok_ns.c: In function ‘findEncodingNS’:
../Modules/expat/xmltok.h:276:10: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized]
  276 |   (((enc)->utf8Convert)(enc, fromP, fromLim, toP, toLim))
      |   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../Modules/expat/xmltok.h:276:10: note: by argument 5 of type ‘const char *’ to ‘XML_Convert_Result <T6d3> (const struct ENCODING *, const char * *, const char *, char * *, const char *)’
In file included from ../Modules/expat/xmltok.c:1665:
../Modules/expat/xmltok_ns.c:96:8: note: ‘buf’ declared here
   96 |   char buf[ENCODING_MAX];
      |        ^~~
lto1: fatal error: error writing to /tmp/ccY9JaSx.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:1170: Programs/_freeze_module] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:2464: clean-retain-profile] Error 1 (ignored)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Feb 4, 2022
@AlexWaygood
unittest deprecations have been deferred until 3.12
958f621
See python/cpython#30935
@AlexWaygood AlexWaygood mentioned this pull request Feb 4, 2022
unittest deprecations have been deferred until 3.12 python/typeshed#7131
Merged
JelleZijlstra pushed a commit to python/typeshed that referenced this pull request Feb 4, 2022
@AlexWaygood
unittest deprecations have been deferred until 3.12 (#7131)
1371a1e
See python/cpython#30935
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Remove old deprecated unittest features #89325
Closed
serhiy-storchaka added a commit that referenced this pull request May 9, 2022
@serhiy-storchaka
Revert "bpo-45162: Revert "Remove many old deprecated unittest featur…
17b4291
…es" (GH-30935)"

This reverts commit b50322d.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 9, 2022
Revert "bpo-45162: Revert "Remove many old deprecated unittest features"" #92556
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 9, 2022
@serhiy-storchaka
Revert "bpo-45162: Revert "Remove many old deprecated unittest featur…
9c94124
…es" (pythonGH-30935)"

This reverts commit b50322d.
@mr-c mr-c mentioned this pull request Nov 16, 2022
Python 3.11: cannot import name '_TextTestResult' from 'unittest.runner' nose-devs/nose#1116
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gpshead @vstinner @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.