GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — bpo-43224: Implement PEP 646 changes to genericaliasobject.c by mrahtz · Pull Request #31019 · python/cpython Conversation
|
|
@pablogsal Might be good to have your eyes on this too, to make sure we get GC correct :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Apologies for the slow reply - it's been a busy couple of weeks! Taking a look at this feedback now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner Done. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 1102d27 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Now it's failing tests because of #31801, sorry for that! Once that's merged you'll have to merge main into your branch again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Main is unbroken now, but I'll see if the current refleak builds say anything; maybe they still tell us something useful even if test_asyncio fails. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
That was fast! I've re-merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit eda60f9 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The refleak buildbots are still unhappy |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Seems like there's a refleak on main. I'll try to find it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@mrahtz I just merged the fix for the refleak into main. Can I trouble you to merge main into this PR again please? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner Wow, that was also fast :) Done. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 5fe058e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks like the buildbots are finally happy! 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I hereby use the non-existent powers vested in me to press the big green button. Thank you Mathew. This was admittedly very tricky.
I will leave this for at least 24 hours for anyone else to give their feedback before I merge.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Congrats @mrahtz ! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Fantastic - thanks @Fidget-Spinner! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.