GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46198: Fix `test_asyncio.test_sslproto` by AlexWaygood · Pull Request #31801 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Mar 10, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

GH-30297 removed a duplicate from test import support statement from test_asyncio.test_sslproto. However, in between that PR being filed and it being merged, GH-31275 removed the other from test import support statement. This means that support is now undefined in test_asyncio.test_sslproto, causing the CI to fail on all platforms for all PRs (e.g. https://github.com/python/cpython/runs/5501039134?check_suite_focus=true)

https://bugs.python.org/issue46198

Automerge-Triggered-By: GH:JelleZijlstra

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
bpo-46198: Fix test_asyncio.test_sslproto
b9e02a7 
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
@AlexWaygood
AlexWaygood requested review from 1st1 and asvetlov as code owners March 10, 2022 21:11
@bedevere-bot bedevere-bot added the awaiting review label Mar 10, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 10, 2022
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 10, 2022
@AlexWaygood AlexWaygood added type-bug An unexpected behavior, bug, or error skip news labels Mar 10, 2022
@AlexWaygood
AlexWaygood requested a review from JelleZijlstra March 10, 2022 21:12
JelleZijlstra
JelleZijlstra approved these changes Mar 10, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks for the catch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 10, 2022
@JelleZijlstra JelleZijlstra added the 🤖 automerge label Mar 10, 2022
@JelleZijlstra

JelleZijlstra commented Mar 10, 2022

Copy link
Copy Markdown
Member

The backports #31796 and #31797 are unaffected because the other import wasn't removed in the 3.9 and 3.10 branches.
AlexWaygood reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

oops, thanks for the catch

It took a little bit of detective work to figure out how it slipped through the CI!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Mar 10, 2022

Copy link
Copy Markdown
Member

Thanks for figuring it out!
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request Mar 10, 2022
bpo-43224: Implement PEP 646 changes to genericaliasobject.c #31019
Merged
@JelleZijlstra
JelleZijlstra merged commit 4052dd2 into python:main Mar 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 10, 2022
@AlexWaygood
AlexWaygood deleted the patch-2 branch March 10, 2022 21:36
@merwok

merwok commented Mar 11, 2022

Copy link
Copy Markdown
Member

I thought we had the check enabled to prevent merging a PR that’s not up to date with the target branch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AlexWaygood @JelleZijlstra @merwok @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.