GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Address more test failures on Emscripten (GH-31050) by tiran · Pull Request #31050 · python/cpython

Conversation

@tiran

@tiran tiran commented Feb 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix wasm32-emscripten test failures and platform issues.

  • Disable syscalls that are not supported or don't work, e.g.
    wait, getrusage, prlimit, mkfifo, mknod, setres[gu]id, setgroups.
  • Use fd_count to cound open fds.
  • Add more checks for subprocess and fork.
  • Add workarounds for missing _multiprocessing and failing socket.accept()
  • Enable bzip2 again
  • Disable large file support
  • Disable signal.alarm for now

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 1, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Feb 1, 2022
@tiran
tiran marked this pull request as ready for review February 1, 2022 14:14
@tiran
tiran requested review from abalkin and pganssle as code owners February 1, 2022 14:14
@tiran
tiran force-pushed the bpo-40280-more-test-fixes branch from e9d6e24 to b34c808 Compare February 1, 2022 16:02
@brettcannon
brettcannon self-requested a review February 1, 2022 19:17
brettcannon
brettcannon approved these changes Feb 4, 2022
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are about recording the known bugs in emscripten and musl so we can easily track when they are fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_os.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pwd.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Build/2022-01-31-15-15-08.bpo-40280.r1AYNW.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/README.md Outdated

@brettcannon brettcannon Feb 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bugs?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/wasm/README.md Outdated

@brettcannon brettcannon Feb 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bug?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Feb 5, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added links to bpo and emscripten bug tracker.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/wasm/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/wasm/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 4, 2022
tiran and others added 9 commits February 5, 2022 17:32
@tiran
bpo-40280: Omit wait, getrusage, and prlimit on Emscripten
165a464
@tiran
bpo-40280: Address more test failures on Emscripten
d9df265
@tiran
disable large file support
fcbc97a
@tiran
Disable signal.alarm
0f8a37c
@tiran
Revert feature check for mknod
ece8f4c
@tiran
Add missing quotes
dd5be39
@tiran
List limitation and known issues
8e39ccd
@tiran @brettcannon
Apply Brett's suggestions
d924247 
Co-authored-by: Brett Cannon <[email protected]>
@tiran
Add links to bugs
5f29e63
@tiran
tiran force-pushed the bpo-40280-more-test-fixes branch from c00edf3 to 5f29e63 Compare February 5, 2022 16:32
@tiran

tiran commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

The failing Windows test is covered by GH-31146
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-40280: Address more test failures on Emscripten bpo-40280: Address more test failures on Emscripten (GH-31050) Feb 5, 2022
@tiran
tiran merged commit 96b344c into python:main Feb 5, 2022
@tiran
tiran deleted the bpo-40280-more-test-fixes branch February 5, 2022 19:52
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 5, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@abalkin abalkin Awaiting requested review from abalkin
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.