GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46656: Remove Py_NO_NAN macro by vstinner · Pull Request #31160 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Building Python now requires support for floating point Not-a-Number
(NaN): remove the Py_NO_NAN macro.

https://bugs.python.org/issue46656

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 6, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Feb 6, 2022
@vstinner

vstinner commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

Windows (x86) (pull_request) Failing after 14m — Windows (x86)

That's the urllib failure. I rebased my PR on the main branch to get the urllib test fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mdickinson

mdickinson commented Feb 6, 2022

Copy link
Copy Markdown
Member

@vstinner This is a big change: historically, CPython has been relunctant to commit to requiring IEEE 754 floating-point. While requiring NaNs isn't exactly the same as requiring IEEE 754 floating-point, it's pretty close. I think this change should be discussed more widely before any change is made to the source.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner marked this pull request as draft February 6, 2022 21:51
@vstinner

vstinner commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

@vstinner This is a big change: historically, CPython has been relunctant to commit to requiring IEEE 754 floating-point. While requiring NaNs isn't exactly the same as requiring IEEE 754 floating-point, it's pretty close. I think this change should be discussed more widely before any change is made to the source.

Ok. I convert my PR to a draft to not merge it by mistake :-D

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

Requiring IEEE 754 support is being discussed on python-dev: https://mail.python.org/archives/list/[email protected]/thread/J5FSP6J4EITPY5C2UJI7HSL2GQCTCUWN/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

Following the python-dev discussion, I proposed a PR for PEP 7 to support C99 in the Python C API (and use a subset of C11 in Python internals): python/peps#2309

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
bpo-46656: Remove Py_NO_NAN macro
d18ddff
Building Python now requires support for floating point Not-a-Number
(NaN): remove the Py_NO_NAN macro.
@vstinner
vstinner marked this pull request as ready for review February 24, 2022 23:48
@vstinner

vstinner commented Feb 24, 2022

Copy link
Copy Markdown
Member Author

Requiring IEEE 754 support is being discussed on python-dev: https://mail.python.org/archives/list/[email protected]/thread/J5FSP6J4EITPY5C2UJI7HSL2GQCTCUWN/

The consensus is to require NAN and IEEE 754 to build Python 3.11. Moreover, Python 3.11 now requires a C11 compiler: #31557

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 1b2611e into python:main Feb 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 25, 2022
@vstinner
vstinner deleted the remove_py_no_nan branch February 25, 2022 00:33
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@vstinner @asvetlov
bpo-46656: Remove Py_NO_NAN macro (GH-31160)
c8946ad
Building Python now requires support for floating point Not-a-Number
(NaN): remove the Py_NO_NAN macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @mdickinson @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.