GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) by miss-islington · Pull Request #31173 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue46648

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
bpo-46648: Skip test_urllib2.test_issue16464() (pythonGH-31161)
1776f8c 
POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 6, 2022
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Feb 6, 2022
@bedevere-bot bedevere-bot mentioned this pull request Feb 6, 2022
bpo-46648: Skip test_urllib2.test_issue16464() #31161
Merged
@miss-islington

miss-islington commented Feb 6, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Feb 6, 2022
@vstinner

vstinner commented Feb 6, 2022

Copy link
Copy Markdown
Member

@ambv: You may want to get this fix. The 10 Refleaks 3.8 buildbots are failing because of test_urllib2: https://buildbot.python.org/all/#/release_status
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 6, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Feb 7, 2022

Copy link
Copy Markdown
Member

fwiw, a more proper fix to backport is coming in #31186. but it probably doesn't matter which one is chosen for 3.8 as it's not like the code this is testing behavior of could ever change in this branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv mentioned this pull request Feb 8, 2022
bpo-46648: move test_issue16464 to urllib2_localnet #31186
Merged
@ambv
ambv merged commit f87e616 into python:3.8 Feb 8, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Feb 8, 2022
@miss-islington
miss-islington deleted the backport-1578de2-3.8 branch February 8, 2022 09:52
@vstinner

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member

Thanks for the merge @ambv!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @vstinner @gpshead @ambv @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.