GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46648: move `test_issue16464` to `urllib2_localnet` by sobolevn · Pull Request #31186 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 7, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I moved the flaky test to test_urllib2_localnet as @gpshead suggested.
I hope that it will now be reliable 🎉

https://bugs.python.org/issue46648

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GBeauregard reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@sobolevn
bpo-46648: move test_issue16464 to urllib2_localnet
6625491
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 7, 2022
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Feb 7, 2022
@sobolevn
sobolevn requested review from gpshead and vstinner February 7, 2022 08:38
@sobolevn sobolevn added the skip news label Feb 7, 2022
gpshead
gpshead approved these changes Feb 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 7, 2022
@gpshead gpshead added needs backport to 3.9 labels Feb 7, 2022
@gpshead gpshead mentioned this pull request Feb 7, 2022
[3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) #31173
Merged
raghavthind2005
raghavthind2005 approved these changes Feb 7, 2022
View reviewed changes
@vstinner
vstinner merged commit 8e98175 into python:main Feb 7, 2022
@miss-islington

miss-islington commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@sobolevn @miss-islington
bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP s…
5543dea 
…erver (pythonGH-31186)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 7, 2022

Copy link
Copy Markdown

GH-31189 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@sobolevn @miss-islington
bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP s…
5cdba55 
…erver (pythonGH-31186)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev <[email protected]>
@vstinner

vstinner commented Feb 7, 2022

Copy link
Copy Markdown
Member

PR merged, thanks. I rewrote the commit title/description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Feb 7, 2022
@bedevere-bot

bedevere-bot commented Feb 7, 2022

Copy link
Copy Markdown

GH-31190 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @sobolevn
bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP s…
0d74efc 
…erver (GH-31186)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @sobolevn
[3.10] bpo-46648: Rewrite test_urllib2.test_issue16464() with a local…
9539400 
… HTTP server (GH-31186) (GH-31189)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)


Co-authored-by: Nikita Sobolev <[email protected]>
@ambv ambv added the needs backport to 3.8 label Feb 8, 2022
@miss-islington

miss-islington commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e98175a03fe03d62822d96007a74e5273013764 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Feb 8, 2022
@ambv ambv removed the needs backport to 3.8 label Feb 8, 2022
@ambv

ambv commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

OK, nevermind, I'll use GH-31173 instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @sobolevn @hello-adam
bpo-46648: Rewrite test_urllib2.test_issue16464() with a local HTTP s…
3969680 
…erver (pythonGH-31186)

Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet
and use the local HTTP server rather than an external HTTP server.
(cherry picked from commit 8e98175)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@vstinner vstinner Awaiting requested review from vstinner
+1 more reviewer
@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@sobolevn @miss-islington @bedevere-bot @vstinner @ambv @gpshead @raghavthind2005 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.