GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153) by miss-islington · Pull Request #31183 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz [email protected]

https://bugs.python.org/issue40479

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz @miss-islington
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
7f643ec 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
@miss-islington
miss-islington requested a review from tiran as a code owner February 7, 2022 07:41
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 7, 2022
@bedevere-bot bedevere-bot mentioned this pull request Feb 7, 2022
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c #31153
Merged
@bedevere-bot bedevere-bot added the awaiting review label Feb 7, 2022
tiran
tiran approved these changes Feb 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 7, 2022
@tiran tiran added the 🤖 automerge label Feb 7, 2022
@miss-islington

miss-islington commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

@ZackerySpytz: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 3ceff99 into python:3.10 Feb 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 7, 2022
@miss-islington
miss-islington deleted the backport-59e004a-3.10 branch February 7, 2022 08:05
@tiran tiran mentioned this pull request May 9, 2022
Port _hashlib to OpenSSL 3.0.0 #84659
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @tiran @the-knights-who-say-ni @bedevere-bot @ZackerySpytz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.