GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c by ZackerySpytz · Pull Request #31153 · python/cpython

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Feb 6, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

va_end() must be called before returning.

https://bugs.python.org/issue40479

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c
91f7297
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 6, 2022
@bedevere-bot bedevere-bot added the awaiting review label Feb 6, 2022
@ZackerySpytz

ZackerySpytz commented Feb 6, 2022

Copy link
Copy Markdown
Contributor Author

This is a skip news PR.

The va_start() calls could be moved next to PyErr_FormatV().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran approved these changes Feb 6, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 6, 2022
tiran
tiran suggested changes Feb 6, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news entry. The problematic code is in releases 3.9.10 and 3.10.2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting merge labels Feb 6, 2022
@bedevere-bot

bedevere-bot commented Feb 6, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added needs backport to 3.9 labels Feb 6, 2022
@ZackerySpytz
News entry.
4c67ecd
@ZackerySpytz

ZackerySpytz commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Feb 7, 2022
@bedevere-bot

bedevere-bot commented Feb 7, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from tiran February 7, 2022 07:35
tiran
tiran approved these changes Feb 7, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Feb 7, 2022
@tiran tiran added the 🤖 automerge label Feb 7, 2022
@miss-islington
miss-islington merged commit 59e004a into python:main Feb 7, 2022
@miss-islington

miss-islington commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@ZackerySpytz @miss-islington
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
7f643ec 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 7, 2022
@bedevere-bot

bedevere-bot commented Feb 7, 2022

Copy link
Copy Markdown

GH-31183 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@ZackerySpytz @miss-islington
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
4749a15 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 7, 2022

Copy link
Copy Markdown

GH-31184 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Feb 7, 2022
miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @ZackerySpytz
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153)
3ceff99 
va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @ZackerySpytz
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153)
0892a0e 
va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
@tiran tiran mentioned this pull request May 9, 2022
Port _hashlib to OpenSSL 3.0.0 #84659
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @ZackerySpytz @hello-adam
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
2dd2e18 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ZackerySpytz @bedevere-bot @miss-islington @tiran @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.