GeezerVison is showing github.com — [3.9] bpo-46615: Don't crash when set operations mutate the sets (GH-31120) by sweeneyde · Pull Request #31312 · python/cpython
Conversation
sweeneyde
commented
Feb 13, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Ensure strong references are acquired whenever using set_next(). Added randomized test cases for __eq__ methods that sometimes mutate sets when called.
(cherry picked from commit 4a66615)
https://bugs.python.org/issue46615
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…31120)
Ensure strong references are acquired whenever using `set_next()`. Added randomized test cases for `__eq__` methods that sometimes mutate sets when called.
(cherry picked from commit 4a66615)
|
|
key = entry->key;
|
|
|
hash = entry->hash;
|
|
|
Py_INCREF(key);
|
|
|
rv = _PyDict_Contains(other, key, hash);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: cherry-picker only struggled because this is _PyDict_Contains_KnownHash() in main.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…31120) (pythonGH-31312)
Ensure strong references are acquired whenever using `set_next()`. Added randomized test cases for `__eq__` methods that sometimes mutate sets when called.
(cherry picked from commit 4a66615)
Reviewers
rhettinger
Awaiting requested review from rhettinger
rhettinger is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
type-bug
An unexpected behavior, bug, or error
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.