GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46752: Slight improvements to TaskGroup API by gvanrossum · Pull Request #31398 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 17, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Remove the optional name argument to the TaskGroup constructor
  • Add an optional name argument to the create_task() method
  • Some cleanup

Note that there's a big discussion on cancellation edge cases going on in bpo-46771, this is unrelated to that and uncontroversial.

I'll also update typeshed.

https://bugs.python.org/issue46752

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum added 3 commits February 16, 2022 18:24
@gvanrossum
Remove task group names (for now)
32468ef 
We're not sure that they are needed, and once in the code
we would never be able to get rid of them.

Yury wrote:

> Ideally, there should be a way for someone to build a "trace"
> of taskgroups/task leading to the current running task.
> We could do that using contextvars, but I'm not sure we should
> do that in 3.11.
@gvanrossum
Pass name on to task in create_task()
d1191ca
@gvanrossum
Remove a bunch of unused stuff
220bb6d
@gvanrossum
gvanrossum requested review from 1st1 and asvetlov as code owners February 17, 2022 23:58
@bedevere-bot bedevere-bot added the awaiting core review label Feb 17, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 17, 2022
gvanrossum added a commit to python/typeshed that referenced this pull request Feb 18, 2022
@gvanrossum
Add optional name arg to create_task()
96ee45f 
See python/cpython#31398
@gvanrossum gvanrossum mentioned this pull request Feb 18, 2022
Tweaks to the TaskGroup API python/typeshed#7255
Merged
@gvanrossum gvanrossum added the skip news label Feb 18, 2022
1st1
1st1 approved these changes Feb 18, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 18, 2022
@gvanrossum
gvanrossum merged commit d851216 into python:main Feb 18, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 18, 2022
@gvanrossum
gvanrossum deleted the rm-tg-name branch February 18, 2022 05:30
gvanrossum added a commit to python/typeshed that referenced this pull request Feb 18, 2022
@gvanrossum
Tweaks to the TaskGroup API (#7255)
644d554 
* Remove TaskGroup name arg and get_name() method

(We removed those from the implementation.)

* Add optional name arg to create_task()

See python/cpython#31398
@gvanrossum gvanrossum mentioned this pull request Apr 27, 2022
Introduce task groups to asyncio and change task cancellation semantics #90908
Closed
@gvanrossum gvanrossum mentioned this pull request May 24, 2022
Implement asyncio.timeout() context manager #90927
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gvanrossum @1st1 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.