GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46787: Fix `ProcessPoolExecutor` exception memory leak by themylogin · Pull Request #31408 · python/cpython

Conversation

@themylogin

@themylogin themylogin commented Feb 18, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46787

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label Feb 18, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Feb 18, 2022
@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 18, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@themylogin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@themylogin themylogin changed the title bpo-NNNN: Fix ProcessPoolExecutor exception memory leak bpo-46787: Fix ProcessPoolExecutor exception memory leak Feb 18, 2022
@themylogin
themylogin force-pushed the bpo-46787 branch from dc793af to c95e51a Compare February 18, 2022 15:24
@themylogin
themylogin force-pushed the bpo-46787 branch from c95e51a to 93252c9 Compare February 18, 2022 15:53
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Feb 18, 2022
@themylogin
themylogin force-pushed the bpo-46787 branch from 93252c9 to 531d826 Compare February 18, 2022 19:10
JelleZijlstra
JelleZijlstra reviewed Feb 19, 2022
View reviewed changes
Comment thread Lib/concurrent/futures/process.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
a7fa191 
…31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
@themylogin
themylogin force-pushed the bpo-46787 branch from 531d826 to a7fa191 Compare February 19, 2022 08:05
@JelleZijlstra
Merge branch 'main' into bpo-46787
3a50834
JelleZijlstra
JelleZijlstra approved these changes May 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 2, 2022
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 labels May 2, 2022
@JelleZijlstra
JelleZijlstra merged commit 9c204b1 into python:main May 2, 2022
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @themylogin for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.10 labels May 2, 2022
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92187 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 2, 2022
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92188 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@themylogin @miss-islington
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
0890e92 
…31408) (pythonGH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <[email protected]>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (GH-31408) (…
c467812 
…GH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <[email protected]>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (GH-31408) (…
51b885a 
…GH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <[email protected]>
@AlexWaygood AlexWaygood mentioned this pull request May 3, 2022
test_concurrent_futures sometimes hangs indefinitely on Windows #92222
Closed
@themylogin themylogin mannequin mentioned this pull request Apr 10, 2022
ProcessPoolExecutor exception memory leak #90943
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @themylogin @hello-adam
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
9d6752a 
…31408) (pythonGH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@themylogin @the-knights-who-say-ni @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.