GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45459: C API uses type names rather than structure names by vstinner · Pull Request #31528 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 23, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45459

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Feb 23, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Feb 23, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 23, 2022
@vstinner vstinner mentioned this pull request Feb 23, 2022
bpo-45459: Add pytypedefs.h header file #31527
Merged
@vstinner
bpo-45459: C API uses type names rather than structure names
8399ccc 
Thanks to the new pytypedefs.h, it becomes to use type names like
PyObject rather like structure names like "struct _object".
@vstinner
vstinner marked this pull request as ready for review February 24, 2022 16:09
@vstinner
vstinner requested review from brettcannon, encukou, ericsnowcurrently, markshannon, methane, ncoghlan and warsaw as code owners February 24, 2022 16:09
methane
methane approved these changes Feb 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 24, 2022
@vstinner
vstinner merged commit 042f31d into python:main Feb 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 24, 2022
@vstinner

vstinner commented Feb 24, 2022

Copy link
Copy Markdown
Member Author

@methane: Oh thanks for the review :-) I wasn't sure if this change was worth it. It's now merged!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the rename_struct branch February 24, 2022 16:52
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@vstinner @asvetlov
bpo-45459: C API uses type names rather than structure names (GH-31528)
eaac871 
Thanks to the new pytypedefs.h, it becomes to use type names like
PyObject rather like structure names like "struct _object".
@tiran tiran mentioned this pull request Mar 3, 2022
Cryptography does not build with python and fails at trying to build _openssl.c pyca/cryptography#6929
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @methane @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.