GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46836: Move PyFrameObject to pycore_frame.h by vstinner · Pull Request #31530 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 23, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move the PyFrameObject type definition (struct _frame) to the
internal C API: to the pycore_frame.h header file.

https://bugs.python.org/issue46836

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Feb 23, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 23, 2022
@vstinner

vstinner commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

I marked this PR as a draft since this change is an incompatible change: see https://bugs.python.org/issue46836#msg413805

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner marked this pull request as ready for review February 24, 2022 15:44
@vstinner
bpo-46836: Move PyFrameObject to pycore_frame.h
cdf9ff2
Move the PyFrameObject type definition (struct _frame) to the
internal C API pycore_frame.h header file.
@vstinner
vstinner merged commit 18b5dd6 into python:main Feb 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 25, 2022
@vstinner
vstinner deleted the internal_frame branch February 25, 2022 11:53
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@vstinner @asvetlov
bpo-46836: Move PyFrameObject to pycore_frame.h (GH-31530)
ed1e6d6
Move the PyFrameObject type definition (struct _frame) to the
internal C API pycore_frame.h header file.
@tacaswell tacaswell mentioned this pull request Feb 26, 2022
FIX: import internal cpython headers to fix for py311 cython/cython#4667
Merged
tacaswell added a commit to tacaswell/pybind11 that referenced this pull request Feb 27, 2022
@tacaswell
FIX: support python311
87a5a71
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

the _frame struct was moved to an internal header, however the public API is
primarily read-only.
@tacaswell tacaswell mentioned this pull request Feb 27, 2022
FIX: support python311 pybind/pybind11#3762
Closed
tacaswell added a commit to tacaswell/cython that referenced this pull request Feb 27, 2022
@tacaswell
FIX: import internal cpython headers to fix for py311
952fc89
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

The `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and cython needs to build _frame objects so still import
the internal headers.
@tacaswell tacaswell mentioned this pull request Mar 1, 2022
Compatibility with Python3.11 (again) python-greenlet/greenlet#288
Closed
tacaswell added a commit to tacaswell/cython that referenced this pull request Mar 4, 2022
@tacaswell
FIX: import internal cpython headers to fix for py311
a83fbaa
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

The `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and cython needs to build _frame objects so still import
the internal headers.
scoder pushed a commit to cython/cython that referenced this pull request Mar 12, 2022
@tacaswell
Import internal CPython frame header file in Python 3.11 (GH-4667)
7537910
In python/cpython#31530
https://bugs.python.org/issue46836

the `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and Cython needs to build PyFrameObjects so still import
the internal headers.

Also sets the Py_BUILD_CORE define for py311a6, trying to restrict it to the frame header.
scoder pushed a commit to cython/cython that referenced this pull request Mar 12, 2022
@tacaswell @scoder
Import internal CPython frame header file in Python 3.11 (GH-4667)
afc00fc
In python/cpython#31530
https://bugs.python.org/issue46836

the `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and Cython needs to build PyFrameObjects so still import
the internal headers.

Also sets the Py_BUILD_CORE define for py311a6, trying to restrict it to the frame header.
@vstinner vstinner mentioned this pull request May 2, 2022
[C API] Move PyFrameObject to the internal C API #90992
Closed
@97littleleaf11 97littleleaf11 mentioned this pull request May 22, 2022
[mypyc] Fix Python 3.11 C API errors python/mypy#12850
Merged
JukkaL pushed a commit to python/mypy that referenced this pull request May 23, 2022
@97littleleaf11
[mypyc] Fix Python 3.11 C API errors (#12850)
c8efeed
Closes mypyc/mypyc#931
Closes mypyc/mypyc#923

Related CPython modification:

python/cpython#89874
python/cpython#31530
@encukou encukou mentioned this pull request Mar 7, 2025
Cython cannot use "pycore_frame.h" in Py3.14a4 #130931
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.