GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Fix winreg reference leaks by vstinner · Pull Request #31560 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Clear also the PyHKEY_Type static type at exit.

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-1635741: Fix winreg reference leaks
bb8dbca 
Clear also the PyHKEY_Type static type at exit.
@vstinner vstinner added the skip news label Feb 25, 2022
@vstinner
vstinner requested a review from a team as a code owner February 25, 2022 02:02
@bedevere-bot bedevere-bot added the awaiting core review label Feb 25, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 25, 2022
@vstinner

vstinner commented Feb 25, 2022

Copy link
Copy Markdown
Member Author

With this range, it remains a leak of 1 reference on Windows:

$ python -I -X showrefcount -c pass
[1 refs, 1 blocks]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Feb 25, 2022
bpo-1635741: test_embed cheks that Python does not leak #31555
Merged
@vstinner
vstinner merged commit 4657bf7 into python:main Feb 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 25, 2022
@vstinner
vstinner deleted the winreg_refleak branch February 25, 2022 11:34
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@vstinner @asvetlov
bpo-1635741: Fix winreg reference leaks (GH-31560)
c6d0b5e 
Clear also the PyHKEY_Type static type at exit.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.