GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-46878: Purge 'non-standard' from sqlite3 docstrings by erlend-aasland · Pull Request #31612 · python/cpython

Conversation

erlend-aasland commented Feb 28, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

https://bugs.python.org/issue46878

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-46878: Purge 'non-standard' from sqlite3 docstrings

a8ebe19

erlend-aasland requested a review from berkerpeksag as a code owner

February 28, 2022 10:53

bedevere-bot added the awaiting review label

Feb 28, 2022

the-knights-who-say-ni added the CLA signed label

Feb 28, 2022

erlend-aasland requested a review from JelleZijlstra

February 28, 2022 10:53

erlend-aasland added the skip news label

Feb 28, 2022

erlend-aasland mentioned this pull request

Feb 28, 2022

bpo-41930: Add support for SQLite serialise/deserialise API #26728

Merged

AlexWaygood added the docs Documentation in the Doc dir label

Feb 28, 2022

JelleZijlstra self-assigned this

Feb 28, 2022

JelleZijlstra approved these changes

Mar 2, 2022

View reviewed changes

JelleZijlstra left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Do you think we should backport this change? I imagine it will make future backports easier if we keep the docstrings similar.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_sqlite/module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting core review and removed awaiting review labels

Mar 2, 2022

erlend-aasland commented Mar 2, 2022

Copy link

Copy Markdown

Contributor Author

Looks good, thanks.

Thanks for reviewing! Much appreciated.

Do you think we should backport this change? I imagine it will make future backports easier if we keep the docstrings similar.

Definitely.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added needs backport to 3.9 labels

Mar 2, 2022

gpshead approved these changes

Mar 4, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Mar 4, 2022

JelleZijlstra commented Mar 8, 2022

Copy link

Copy Markdown

Member

Going to merge this change soon (cc @gvanrossum).

gvanrossum reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra merged commit 4d95fa1 into python:main

Mar 8, 2022

miss-islington commented Mar 8, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Mar 8, 2022

miss-islington commented Mar 8, 2022

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4d95fa1ac5d31ff450fb2f31b55ce1eb99d6efcb 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 8, 2022

Copy link

Copy Markdown

Contributor

Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4d95fa1ac5d31ff450fb2f31b55ce1eb99d6efcb 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland deleted the sqlite-non-standard branch

March 8, 2022 08:25

bedevere-bot removed the needs backport to 3.10 label

Mar 8, 2022

bedevere-bot commented Mar 8, 2022

Copy link

Copy Markdown

GH-31753 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

Mar 8, 2022

[3.10] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612) #31753

Merged

bedevere-bot removed the needs backport to 3.9 label

Mar 8, 2022

bedevere-bot commented Mar 8, 2022

Copy link

Copy Markdown

GH-31754 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

Mar 8, 2022

[3.9] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612) #31754

Merged

miss-islington pushed a commit that referenced this pull request

Mar 8, 2022


          [3.10] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612

f3d3b2d

) (GH-31753)

(cherry picked from commit 4d95fa1)

miss-islington pushed a commit that referenced this pull request

Mar 8, 2022


          [3.9] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612…

653ca6c

…) (GH-31754)

(cherry picked from commit 4d95fa1)

erlend-aasland mentioned this pull request

Apr 10, 2022

[sqlite3] remove "non-standard" from docstrings #91034

Closed

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022


          [3.9] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (python…

fbff1e0

…GH-31612) (pythonGH-31754)

(cherry picked from commit 4d95fa1)

Reviewers

gpshead

gpshead approved these changes

JelleZijlstra

JelleZijlstra approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Feb 28, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland commented Mar 2, 2022

Uh oh!

JelleZijlstra commented Mar 8, 2022

Uh oh!

miss-islington commented Mar 8, 2022

Uh oh!

miss-islington commented Mar 8, 2022

Uh oh!

miss-islington commented Mar 8, 2022

Uh oh!

bedevere-bot commented Mar 8, 2022

Uh oh!

bedevere-bot commented Mar 8, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

erlend-aasland commented Feb 28, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.