GeezerVison is showing github.com — bpo-46841: Fix error message hacks in `GET_AWAITABLE` by brandtbucher · Pull Request #31664 · python/cpython
Conversation
brandtbucher
commented
Mar 3, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The existing code was already quite sensitive to small changes in the compiler, but it is also now technically incorrect (due to the recent addition of inline bytecode caches).
We have all the context we need in the compiler, so a normal oparg can be used as a much simpler mechanism for achieving the same effect.
https://bugs.python.org/issue46841
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
👍 to one less hack in the async/await implementation.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.