GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46841: Fix `BINARY_OP`'s handling of inline caches by brandtbucher · Pull Request #31671 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Mar 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 2 commits March 3, 2022 14:30
@brandtbucher
Handle cache entries correctly in BINARY_OP
fac0477
@brandtbucher
blurb add
f5d3c19
@brandtbucher
brandtbucher requested a review from markshannon as a code owner March 3, 2022 22:36
@bedevere-bot bedevere-bot added the awaiting core review label Mar 3, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 3, 2022
@brandtbucher brandtbucher mentioned this pull request Mar 3, 2022
Inline caching faster-cpython/ideas#310
Closed
21 of 26 tasks
@markshannon

markshannon commented Mar 4, 2022

Copy link
Copy Markdown
Member

Changes LGTM.

OOI, how did you find this?

Would it be feasible to add a regression test?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Mar 4, 2022

Copy link
Copy Markdown
Member Author

OOI, how did you find this?

After the LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE issue on #31640, I went through both these files and reviewed our use of instruction pointers. #31664 came out of that too.

Would it be feasible to add a regression test?

Not until we can dis quickened code. Once that happens, I can go through and add a new suite of test cases for all of our adaptive/specialized/super instructions.

Don't worry, it will be less like test_dis.py and more like test_peepholer.py. ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher
brandtbucher merged commit c4d2d57 into python:main Mar 4, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 4, 2022
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Inline bytecode caches #90997
Closed
@brandtbucher
brandtbucher deleted the binary-op-fix branch July 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.