GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace key if not identical to old key in dict by malthe · Pull Request #31685 · python/cpython

Conversation

@malthe

@malthe malthe commented Mar 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This fixes an issue in dict and by extension in weakref.WeakKeyDictionary which arises when a key that is equal to an existing key is used to set a new value – where the key itself is not replaced.

To appreciate this situation, consider when the keys are type weakref.ref.

In this case, the lifetime of the key after replacing the value is now that of the initial key and not the one that's been set subsequently – since the key entry is still the initial object. If the first key falls to refcount zero, the key is removed from the weakref.WeakKeyDictionary – which is unexpected because we have set a newer key which might have refcount greater than zero.

In the general case where a value is replaced for the exact same key (object identity), there is no practical difference with this change – and when a new key is used to replace a value, the cost is only a write to memory.

Thanks to @potiuk and @ashb for helping finding this issue which was discovered during flaky test runs in Apache Airflow.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

potiuk and arhadthedev reacted with thumbs up emoji potiuk reacted with rocket emoji potiuk reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 🚀 1 reaction
  • 👀 1 reaction
@bedevere-bot bedevere-bot added the awaiting review label Mar 4, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 4, 2022
@potiuk

potiuk commented Mar 4, 2022

Copy link
Copy Markdown

Nice :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

potiuk added a commit to apache/airflow that referenced this pull request Mar 4, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
1949f5d
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found 
python/cpython#31685
@malthe
malthe force-pushed the fix-weakref-key-replacement branch from f572737 to 4f8c6b6 Compare March 4, 2022 23:10
@malthe
malthe requested review from markshannon and methane as code owners March 4, 2022 23:10
@malthe malthe changed the title Keys should always be replaced in WeakKeyDictionary Replace key if not identical to old key in dict Mar 4, 2022
@malthe
Replace key if not identical to old key
0fd074a
@malthe
malthe force-pushed the fix-weakref-key-replacement branch from 4f8c6b6 to 0fd074a Compare March 4, 2022 23:20
@methane

methane commented Mar 5, 2022

Copy link
Copy Markdown
Member

Thank you for first pull request. But we need an issue on bugs.python.org unless the pull request don't change any behavior (e.g. fixing typo, code cleanup).

But we are planning to moving issue tracker from bugs.python.org to GitHub issues in this month.
https://discuss.python.org/t/github-issues-migration-is-coming-soon/13791

  • All issues are copied to the GitHub issues.
  • During the migration (3-5 days estimated), you can not use both of bugs.python.org and GitHub issues.
  • If you don't want to learn bugs.python.org only for few days, I recommend to wait the migration finished.

In the general case where a value is replaced for the exact same key (object identity), there is no practical difference with this change – and when a new key is used to replace a value, the cost is only a write to memory.

This change is not so easy as you think. In Python, True == 1, False == 0, 2.0 == 2. We guaranteed "first wins" semantics for very long time. So it is not an option to change the dict.

I recommend you to start discussion in:

  • Ideas category on discuss.python.org, or
  • Python-dev mailing list

Both discussion can be used during issue tracker migration.

When posting your idea on the discussion, please describe your use case more concretely.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rhettinger rhettinger closed this Mar 5, 2022
@ashb

ashb commented Mar 7, 2022

Copy link
Copy Markdown

@malthe Might be worth turning this in to a doc update to mention this "gotcha" for the next people?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@potiuk

potiuk commented Mar 7, 2022

Copy link
Copy Markdown

@malthe Might be worth turning this in to a doc update to mention this "gotcha" for the next people?

Yep. We already asked for it https://bugs.python.org/issue46925 and Python maintainers agreed it's a good thing to do and reopened the issue to be "doc-issue".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ephraimbuddy pushed a commit to apache/airflow that referenced this pull request Mar 23, 2022
@potiuk @ephraimbuddy
Change the storage of frame to use threadLocal rather than Dict (#21993)
0fd0b1b
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

(cherry picked from commit 1949f5d)
ephraimbuddy pushed a commit to apache/airflow that referenced this pull request Mar 24, 2022
@potiuk @ephraimbuddy
Change the storage of frame to use threadLocal rather than Dict (#21993)
7b532cb
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

(cherry picked from commit 1949f5d)
ephraimbuddy pushed a commit to apache/airflow that referenced this pull request Mar 26, 2022
@potiuk @ephraimbuddy
Change the storage of frame to use threadLocal rather than Dict (#21993)
91b95ea
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

(cherry picked from commit 1949f5d)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
652c8da
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

(cherry picked from commit 1949f5d76b5842d56db91c868ae4655bb7a7689f)

GitOrigin-RevId: 91b95ea6633bc14ca9bdefe5eac0ac948465dfc9
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 10, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
7681a4b
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 30, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
f681853
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
85e663b
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
c1f4b97
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
5736311
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
@malthe malthe mannequin mentioned this pull request Apr 10, 2022
Document dict behavior when setting equal but not identical key #91081
Closed
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
a5505a0
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
29467c3
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2024
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
3915e27
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
96bae6c
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 2, 2025
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
aaedb7d
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 23, 2025
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
7919e92
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 18, 2025
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
0463980
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 16, 2025
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
474d532
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 21, 2026
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
6b975ce
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 27, 2026
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
4a2c2ef
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 23, 2026
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
0701301
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 24, 2026
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
10e043e
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 30, 2026
@potiuk
Change the storage of frame to use threadLocal rather than Dict (#21993)
2ad60c8
There is a very probable WeakKeyDict bug in Python standard
library (to be confirmed and investigated further) that
manifests itself in a very rare failure of the
test_stacktrace_on_failure_starts_with_task_execute_method

This turned out to be related to an unexpected behaviour
(and most likely a bug - to be confirmed) of WeakKeyDict
when you have potentially two different objects with the
same `equals` and `hash` values added to the same
WeakKeyDict as keys.

More info on similar report (but raised for a bit different
reason) bug in Python can be found here:

https://bugs.python.org/issue44140

We submitted a PR to fix the problem found
python/cpython#31685

GitOrigin-RevId: 1949f5d76b5842d56db91c868ae4655bb7a7689f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@malthe @potiuk @methane @ashb @rhettinger @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.