GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port _tkinter to PY_STDLIB_MOD by erlend-aasland · Pull Request #31698 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 5, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Remove --with-tclk-* options from configure
  • Use pkg-config to detect _tkinter dependencies (Tcl/Tk, X11)
  • Manual override via environment variables TCLTK_CFLAGS and TCLTK_LIBS

https://bugs.python.org/issue45847

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland
Remove obsolete HAVE_UCS4_TCL check
0aee55a
@bedevere-bot bedevere-bot added the awaiting review label Mar 5, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 5, 2022
@erlend-aasland erlend-aasland added the DO-NOT-MERGE label Mar 5, 2022
Erlend E. Aasland
bpo-45847: Port _tkinter to PY_STDLIB_MOD
8c8b74d
@erlend-aasland
erlend-aasland force-pushed the ac-tkinter branch from 854b70e to 8c8b74d Compare March 6, 2022 22:27
Erlend E. Aasland added 2 commits March 6, 2022 23:28
Erlend E. Aasland
Remove dead lines from Setup.stdlib.in
da79509
Erlend E. Aasland
Update What's New
1533c54
@erlend-aasland erlend-aasland added the skip news label Mar 6, 2022
@erlend-aasland

erlend-aasland commented Mar 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Looks like the Ubuntu pkg-config files for Tcl/Tk are buggy; they don't provide the correct --libs flags (-L is wrong).

Resolved in commit a8313a1

Now we've got problems on FreeBSD (14.0): X11/Xlib.h is included by tk.h, X11 include path is not passed toCFLAGS:

$ grep -A5 "cc.*tcl" config.log
configure:12411: cc -o conftest  -I/usr/local/include/tcl8.6 -I/usr/local/include/tk8.6    conftest.c -L/usr/local/lib -ltk86 -ltkstub86 -ltcl86 -ltclstub86   >&5
In file included from conftest.c:111:
/usr/local/include/tk8.6/tk.h:99:13: fatal error: 'X11/Xlib.h' file not found
#   include <X11/Xlib.h>
            ^~~~~~~~~~~~

1 error generated.

$ pkg-config --libs --cflags tcl86 tk86
-I/usr/local/include/tcl8.6 -I/usr/local/include/tk8.6 -L/usr/local/lib -ltk86 -ltkstub86 -ltcl86 -ltclstub86

Proposed solution: add special case for FreeBSD in 72cf592

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 3 commits March 7, 2022 11:59
Erlend E. Aasland
Use LIBS iso. LDFLAGS when compiling conftest
a8313a1
Erlend E. Aasland
Remove references to --with-tclk-* from Doc
f835d6d
Erlend E. Aasland
Add special-case for FreeBSD
72cf592
@erlend-aasland
erlend-aasland force-pushed the ac-tkinter branch from 8af1b25 to 72cf592 Compare March 7, 2022 12:45
@erlend-aasland

erlend-aasland commented Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

(I squeezed 46e43dcaa599d3fe906cdb3ebd591151af856372, 5156b5764a368578e5eb55da471b74e80e5aa479, and 8af1b258d04b042038e0cc0e5fccfd35aad659af into 72cf592)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland changed the title [WIP] bpo-45847: Port _tkinter to PY_STDLIB_MOD bpo-45847: Port _tkinter to PY_STDLIB_MOD Mar 7, 2022
@erlend-aasland erlend-aasland closed this Mar 7, 2022
@erlend-aasland erlend-aasland reopened this Mar 7, 2022
Erlend E. Aasland added 2 commits March 7, 2022 13:54
Erlend E. Aasland
Merge remote-tracking branch 'upstream/main' into ac-tkinter
ff95879
Erlend E. Aasland
Regen configure bco. pythonGH-31700
ea426ef
erlend-aasland
erlend-aasland commented Mar 7, 2022
View reviewed changes
Comment thread configure.ac
Comment on lines +3540 to +3544
#if defined(TK_HEX_VERSION)
# if TK_HEX_VERSION < 0x08040200
# error "Tk older than 8.4.2 not supported"
# endif
#endif

@erlend-aasland erlend-aasland Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this and keep the ones below?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 7, 2022
@bedevere-bot

bedevere-bot commented Mar 7, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ea426ef 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 7, 2022
@erlend-aasland

erlend-aasland commented Mar 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Non-Windows buildbot status embedded below (updating this post at irregular intervals)

TL;DR: macOS and RHEL7 buildbots did no longer build _tkinter (change in behaviour).

There were some other issues which have been addressed:

  • A FreeBSD bot failed because the X11 check lacked a guard. Addressed in 5816799
Buildbot status
Buildbot Post PR Pre PR Status
AMD64 FreeBSD Shared PR error missing 🔴
AMD64 Arch Linux Asan Debug PR yes yes 🟢
AMD64 Arch Linux Asan PR yes yes 🟢
AMD64 Arch Linux TraceRefs PR yes  yes 🟢
AMD64 Arch Linux Usan PR yes  yes 🟢
AMD64 Debian PGO PR yes yes 🟢
AMD64 Debian root PR missing missing 🟢
AMD64 Fedora Stable Clang Installed PR yes  yes 🟢
AMD64 Fedora Stable Clang PR yes yes 🟢
AMD64 Fedora Stable LTO + PGO PR yes yes 🟢
AMD64 Fedora Stable LTO PR yes yes 🟢
AMD64 Fedora Stable PR yes yes 🟢
AMD64 Fedora Stable Refleaks PR yes  yes 🟢
AMD64 RHEL7 LTO + PGO PR missing yes 🔴
AMD64 RHEL7 LTO PR missing yes 🔴
AMD64 RHEL7 PR missing yes 🔴
AMD64 RHEL7 Refleaks PR missing yes 🔴
AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR yes yes 🟢
AMD64 RHEL8 LTO + PGO PR yes yes 🟢
AMD64 RHEL8 LTO PR yes yes 🟢
AMD64 RHEL8 PR yes yes 🟢
AMD64 RHEL8 Refleaks PR yes  yes 🟢
AMD64 Ubuntu Shared PR missing missing 🟢
ARM64 macOS PR missing (deliberate) yes 🟢
PPC64 Fedora PR missing yes 🔴
PPC64LE Fedora Stable Clang Installed PR yes yes 🟢
PPC64LE Fedora Stable Clang PR yes yes 🟢
PPC64LE Fedora Stable LTO + PGO PR yes yes 🟢
PPC64LE Fedora Stable LTO PR yes yes 🟢
PPC64LE Fedora Stable PR yes yes 🟢
PPC64LE Fedora Stable Refleaks PR yes yes 🟢
PPC64LE RHEL7 LTO + PGO PR missing yes 🔴
PPC64LE RHEL7 LTO PR missing yes 🔴
PPC64LE RHEL7 PR missing  yes 🔴
PPC64LE RHEL7 Refleaks PR missing yes 🔴
PPC64LE RHEL8 LTO + PGO PR yes yes 🟢
PPC64LE RHEL8 LTO PR yes  yes 🟢
PPC64LE RHEL8 PR yes yes 🟢
PPC64LE RHEL8 Refleaks PR yes yes 🟢
aarch64 Fedora Stable Clang Installed PR yes yes 🟢
aarch64 Fedora Stable Clang PR yes yes 🟢
aarch64 Fedora Stable LTO + PGO PR  yes yes 🟢
aarch64 Fedora Stable LTO PR yes yes 🟢
aarch64 Fedora Stable PR yes yes 🟢
aarch64 Fedora Stable Refleaks PR yes yes 🟢
aarch64 RHEL8 LTO + PGO PR yes yes 🟢
aarch64 RHEL8 LTO PR yes yes 🟢
aarch64 RHEL8 PR yes yes 🟢
aarch64 RHEL8 Refleaks PR yes yes 🟢
s390x Debian PR yes yes 🟢
s390x Fedora Clang Installed PR yes  yes 🟢
s390x Fedora Clang PR yes yes 🟢
s390x Fedora LTO + PGO PR yes yes 🟢
s390x Fedora LTO PR yes yes 🟢
s390x Fedora PR yes  yes 🟢
s390x Fedora Refleaks PR yes yes 🟢
s390x RHEL7 LTO + PGO PR missing yes 🔴
s390x RHEL7 LTO PR missing yes 🔴
s390x RHEL7 PR missing yes 🔴
s390x RHEL7 Refleaks PR missing  yes 🔴
s390x RHEL8 LTO + PGO PR yes  yes 🟢
s390x RHEL8 LTO PR yes yes 🟢
s390x RHEL8 PR yes  yes 🟢
s390x RHEL8 Refleaks PR yes yes 🟢
s390x SLES PR  yes  yes 🟢
x86 Gentoo Installed with X PR yes  yes 🟢
x86 Gentoo Non-Debug with X PR yes  yes 🟢
x86-64 macOS PR missing (deliberate)  yes 🟢
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits March 7, 2022 23:22
Erlend E. Aasland
Merge branch 'main' into ac-tkinter
27f2dd1
Erlend E. Aasland
Don't break configure if x11 is not found
5816799
@erlend-aasland

erlend-aasland commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Sparked by Ronald's comment on Discourse:

We could add a hack for macOS... I added this on my macOS 12 install, and it works for me. Not sure how it would fare on older installs, though.

--- a/configure.ac
+++ b/configure.ac
@@ -3515,8 +3515,21 @@ for _QUERY in \
 done
 
 AS_VAR_IF([found_tcltk], [no], [
-  TCLTK_CFLAGS=${TCLTK_CFLAGS-""}
-  TCLTK_LIBS=${TCLTK_LIBS-""}
+  AS_CASE([$ac_sys_system],
+    [Darwin*], [
+      TCLTK_CFLAGS=${TCLTK_CFLAGS-"\
+        -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Tcl.framework/Headers \
+        -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Tk.framework/Headers \
+        -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks \
+      "}
+      TCLTK_LIBS=${TCLTK_LIBS-"\
+        -Wl,-F,/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks,-framework,Tcl,-framework,Tk
+      "}
+    ], [
+      TCLTK_CFLAGS=${TCLTK_CFLAGS-""}
+      TCLTK_LIBS=${TCLTK_LIBS-""}
+    ]
+  )
 ])
 
 dnl FreeBSD has an X11 dependency which is not implicitly resolved.

I'm not sure if it's worth it adding a more complex hack, or if it's worth it adding this hack in the first place.

cc. @tiran @ronaldoussoren @ned-deily

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Mar 13, 2022

Copy link
Copy Markdown
Contributor Author

We could add a hack for macOS... I added this on my macOS 12 install, and it works for me. Not sure how it would fare on older installs, though.

Based on comments from Ned and Ronald, I'm dropping adding any hack for macOS; those building on macOS will have to install MacPorts or Homebrew, and explicitly or implicitly pass this information to configure, for example through PKG_CONFIG_PATH.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 13, 2022
@erlend-aasland

erlend-aasland commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

Synced with main to get Serhiy's commits (GH-31839, GH-31938)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 3 commits March 17, 2022 12:13
Erlend E. Aasland
Merge branch 'main' into ac-tkinter
5e9887d
Erlend E. Aasland
make patchcheck
b8ee798
Erlend E. Aasland
Merge remote-tracking branch main into ac-tkinter
0cf682f
@erlend-aasland

erlend-aasland commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

@tiran, do you want another round through the buildbots after I pulled Serhiy's changes? Apart from that, are you fine with this PR as it stands?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily

ned-deily commented Mar 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for the PR! I'd like to review and play with it a bit but I likely won't be able to do so before Monday. If you don't hear anything by then, go ahead.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Mar 27, 2022

Copy link
Copy Markdown
Contributor Author

@ned-deily would you still like to review this?

ned-deily reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily
ned-deily reviewed Mar 29, 2022
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this. Considering the history and complexity, I'm sure some problems will pop up that, at a minimum, will require more documentation, including the devguide with regard to installing dependencies. I did leave a comment about explicitly documenting the removal of the previous configure options. Also FTR, the macOS installer build script at the moment still depends on those current configure options; I will rework that area prior to the next 3.11 alpha.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits March 30, 2022 21:31
Erlend E. Aasland
Merge remote-tracking branch 'upstream/main' into ac-tkinter
1574c1b
Erlend E. Aasland
Address review: document the removal of the configure options
b48d671
@ned-deily

ned-deily commented Mar 31, 2022

Copy link
Copy Markdown
Member

Ready to go

erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Ready to go

Great, thank you for reviewing! @tiran, can you land this? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tiran
tiran approved these changes Mar 31, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 31, 2022
@tiran

tiran commented Mar 31, 2022

Copy link
Copy Markdown
Member

Love it! Your PR removes a lot of complicated code from setup.py.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran added the 🤖 automerge label Mar 31, 2022
@miss-islington
miss-islington merged commit b36d222 into python:main Mar 31, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 31, 2022
@erlend-aasland
erlend-aasland deleted the ac-tkinter branch March 31, 2022 10:35
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Apr 17, 2022
Erlend E. Aasland
pythongh-90005: Cleanup after pythonGH-31698
62957a1
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2022
@erlend-aasland @miss-islington
pythongh-90005: Cleanup after pythonGH-31698 (pythonGH-91642)
2f434cb
(cherry picked from commit 269e726)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request May 9, 2022
@erlend-aasland
gh-90005: Cleanup after GH-31698 (#91642)
269e726
miss-islington added a commit that referenced this pull request May 9, 2022
@miss-islington @erlend-aasland
gh-90005: Cleanup after GH-31698 (GH-91642)
5e2e9c4
(cherry picked from commit 269e726)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@sharewax

sharewax commented Aug 13, 2022

Copy link
Copy Markdown

files from centos7 (tk-devel-8.5.13-6.el7.x86_64 and tcl-devel-8.5.13-8.el7.x86_64) doesn't contain files for pkg-config, so tcl for debug version of python you get

Wl,--enable-new-dtags -g -L/usr/lib64/openssl11 -L/opt/wargaming/wargaming-python311/root/usr/lib64-Wl,-z,relro -Wl,-rpath,/opt/wargaming/wargaming
-python311/root/usr/lib64 -Wl,--enable-new-dtags -g -L/usr/lib64/openssl11 -L/opt/wargaming/wargaming-python311/root/usr/lib64-Wl,-z,relro -Wl,-rpa
th,/opt/wargaming/wargaming-python311/root/usr/lib64 -Wl,--enable-new-dtags -fno-semantic-interposition -g -L/usr/lib64/openssl11 -flto -fuse-linke
r-plugin -ffat-lto-objects -flto-partition=none -g -L/opt/wargaming/wargaming-python311/root/usr/lib64-Wl,-z,relro -Wl,-rpath,/opt/wargaming/wargam
ing-python311/root/usr/lib64 -Wl,--enable-new-dtags -fno-semantic-interposition -g -L/usr/lib64/openssl11 -L/opt/wargaming/wargaming-python311/root
/usr/lib64-Wl,-z,relro -Wl,-rpath,/opt/wargaming/wargaming-python311/root/usr/lib64 -Wl,--enable-new-dtags -g -L/usr/lib64/openssl11 -I/opt/wargami
ng/wargaming-python311/root/usr/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -I/usr/include/openssl11 build/temp.linux-x86_64-3.11-pydebug/builddir/build/
BUILD/Python-3.11.0rc1/Modules/_ctypes/_ctypes.o build/temp.linux-x86_64-3.11-pydebug/builddir/build/BUILD/Python-3.11.0rc1/Modules/_ctypes/callbac
ks.o build/temp.linux-x86_64-3.11-pydebug/builddir/build/BUILD/Python-3.11.0rc1/Modules/_ctypes/callproc.o build/temp.linux-x86_64-3.11-pydebug/bui
lddir/build/BUILD/Python-3.11.0rc1/Modules/_ctypes/cfield.o build/temp.linux-x86_64-3.11-pydebug/builddir/build/BUILD/Python-3.11.0rc1/Modules/_cty
pes/stgdict.o -L. -L/opt/wargaming/wargaming-python311/root/usr/lib64 -L/usr/lib64/openssl11 -L/usr/local/lib -lffi -ldl -o build/lib.linux-x86_64-
3.11-pydebug/_ctypes.cpython-311d-x86_64-linux-gnu.so
*** WARNING: renaming "_tkinter" since importing it failed: /builddir/build/BUILD/Python-3.11.0rc1/build/debug/build/lib.linux-x86_64-3.11-pydebug/_tkinter.cpython-311d-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
Following modules built successfully but were removed because they could not be imported:
_tkinter

I'll try to set manually flags TCLTK_CFLAGS and TCLTK_LIBS, but it seems strage. on python3.10 all works well without additional things.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran

tiran commented Aug 13, 2022

Copy link
Copy Markdown
Member

@sharewax Python 3.11 requires pkg-config to detect and configure tkinter. The CentOS 7 packages do not provide a .pc file for TCL and TK. _tkinter compiles for me with correct TCLTK_LIBS. We should document the correct flags for CentOS7 users. Could you please open a new ticket?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sharewax

sharewax commented Aug 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

@tiran Sure. Can you provide correct TCLTK_LIBS for centos7? I would like to finish my installation correctly :)
added:
export TCLTK_LIBS="-ltk8.5 -ltcl8.5"
solves the issue if add in into spec file near other export variables.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sharewax sharewax mentioned this pull request Aug 13, 2022
_tkinter build issue on Centos7 due changing TK/TCL detection by configure script. #95957
Closed
@asottile asottile mentioned this pull request Nov 3, 2022
3.11 build reports missing _tkinter on Ubuntu 18.04 #98973
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily left review comments
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@erlend-aasland @bedevere-bot @ned-deily @tiran @sharewax @the-knights-who-say-ni @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.