GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Doc: normalise pre-acronym determiners by erlend-aasland · Pull Request #31772 · python/cpython

Conversation

erlend-aasland commented Mar 8, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

For consistency, replace seven instances of "a SQL" with "an SQL" in sqlite3 docs/docstrings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Doc: normalise pre-acronym determiners

5163caf

For consistency, replace "a SQL" with "an SQL".

erlend-aasland requested a review from berkerpeksag as a code owner

March 8, 2022 20:17

bedevere-bot added the awaiting review label

Mar 8, 2022

the-knights-who-say-ni added the CLA signed label

Mar 8, 2022

erlend-aasland commented Mar 8, 2022

Copy link

Copy Markdown

Contributor Author

Triggered by #31753 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from JelleZijlstra

March 8, 2022 20:18

erlend-aasland added skip issue skip news needs backport to 3.9 labels

Mar 8, 2022

JelleZijlstra self-assigned this

Mar 8, 2022

AlexWaygood added the docs Documentation in the Doc dir label

Mar 8, 2022

JelleZijlstra approved these changes

Mar 9, 2022

View reviewed changes

JelleZijlstra left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to make this consistent in the sqlite docs. There are two more instances in howto/functional.rst and Lib/socketserver.py, but I think we can leave those alone since they're not directly about SQLite.

@gvanrossum I'm planning to merge this soon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 9, 2022

JelleZijlstra commented Mar 10, 2022

Copy link

Copy Markdown

Member

There's a merge conflict, could you regenerate Argument Clinic?

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' and regen clinic

816272e

JelleZijlstra merged commit 2d5835a into python:main

Mar 11, 2022

miss-islington commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Mar 11, 2022

miss-islington commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2d5835a019a46573d5b1b614c8ef88d6b564d8d4 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2d5835a019a46573d5b1b614c8ef88d6b564d8d4 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added needs backport to 3.9 and removed needs backport to 3.9 labels

Mar 11, 2022

miss-islington commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Mar 11, 2022

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2d5835a019a46573d5b1b614c8ef88d6b564d8d4 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Mar 11, 2022

bedevere-bot commented Mar 11, 2022

Copy link

Copy Markdown

GH-31806 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request

Mar 11, 2022


          [3.10] sqlite3: normalise pre-acronym determiners (pythonGH-31772)

78803b3

For consistency, replace "a SQL" with "an SQL"..
(cherry picked from commit 2d5835a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot commented Mar 11, 2022

Copy link

Copy Markdown

GH-31807 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.9 label

Mar 11, 2022

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request

Mar 11, 2022


          [3.9] sqlite3: normalise pre-acronym determiners (pythonGH-31772)

78672ae

For consistency, replace "a SQL" with "an SQL"..
(cherry picked from commit 2d5835a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

JelleZijlstra added a commit that referenced this pull request

Mar 12, 2022


          [3.10] sqlite3: normalise pre-acronym determiners (GH-31772) (GH-31806)

d8ba5c1

For consistency, replace "a SQL" with "an SQL"..
(cherry picked from commit 2d5835a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

JelleZijlstra added a commit that referenced this pull request

Mar 12, 2022


          [3.9] sqlite3: normalise pre-acronym determiners (GH-31772) (GH-31807)

49ff5ed

For consistency, replace "a SQL" with "an SQL"..
(cherry picked from commit 2d5835a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request

Jun 2, 2022


          [3.9] sqlite3: normalise pre-acronym determiners (pythonGH-31772) (py…

05c6111

…thonGH-31807)

For consistency, replace "a SQL" with "an SQL"..
(cherry picked from commit 2d5835a)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland mentioned this pull request

Jul 27, 2022

Improve the sqlite3 reference #95273

Closed

5 tasks done

erlend-aasland deleted the es-es-cue-el-no-sequel branch

July 4, 2023 22:50

Reviewers

JelleZijlstra

JelleZijlstra approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Mar 8, 2022

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra commented Mar 10, 2022

Uh oh!

miss-islington commented Mar 11, 2022

Uh oh!

miss-islington commented Mar 11, 2022

Uh oh!

miss-islington commented Mar 11, 2022

Uh oh!

miss-islington commented Mar 11, 2022

Uh oh!

miss-islington commented Mar 11, 2022

Uh oh!

bedevere-bot commented Mar 11, 2022

Uh oh!

bedevere-bot commented Mar 11, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Mar 8, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.