GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45150: draft implementation only for sha224,sha256 by SonOfLilit · Pull Request #31928 · python/cpython

Conversation

@SonOfLilit

@SonOfLilit SonOfLilit commented Mar 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This is only a draft, after review I will write similar code for all other internal hash implementations, as well as for OpenSSL-based implementations.

https://bugs.python.org/issue45150

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SonOfLilit
bpo-45150: draft implementation only for sha224,sha256
34557d9
@SonOfLilit
SonOfLilit requested a review from tiran as a code owner March 16, 2022 02:11
@bedevere-bot bedevere-bot added the awaiting review label Mar 16, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Mar 16, 2022
@the-knights-who-say-ni

the-knights-who-say-ni commented Mar 16, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@SonOfLilit

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Mar 16, 2022
@SonOfLilit
bpo-45150: handle signals
77d08c7
@gpshead
gpshead marked this pull request as draft March 16, 2022 21:07
@gpshead

gpshead commented Mar 16, 2022

Copy link
Copy Markdown
Member

I do not think we should be writing C code for the initial implementation of this feature. I like where #31930 is headed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@tarekziade tarekziade mannequin mentioned this pull request Aug 13, 2022
Add a file_digest() function in hashlib #89313
Closed
@arhadthedev

arhadthedev commented Feb 16, 2023

Copy link
Copy Markdown
Member

Superseded by gh-31930.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran
@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@SonOfLilit @the-knights-who-say-ni @gpshead @arhadthedev @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.