GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45150: Add hashlib.file_digest() for efficient file hashing by tiran · Pull Request #31930 · python/cpython

Conversation

@tiran

@tiran tiran commented Mar 16, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45150

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Techcable reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added the awaiting core review label Mar 16, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 16, 2022
@tiran
tiran force-pushed the bpo-45150-file-digest branch from 1d6869b to 9b218da Compare March 16, 2022 12:33
@tiran
bpo-45150: Add hashlib.file_digest() for efficient file hashing
71f0401
@tiran
tiran force-pushed the bpo-45150-file-digest branch from 9b218da to 71f0401 Compare March 16, 2022 12:38
tiran added 2 commits March 16, 2022 13:50
@tiran
Remove whitespace
85cee7f
@tiran
Doctests are annoying
77df20d
@tiran
tiran requested a review from gpshead March 16, 2022 14:37
gpshead
gpshead requested changes Mar 16, 2022
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you implemented this in pure Python.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/hashlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/hashlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_hashlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/hashlib.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Mar 16, 2022
@bedevere-bot

bedevere-bot commented Mar 16, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead mentioned this pull request Mar 16, 2022
bpo-45150: draft implementation only for sha224,sha256 #31928
Closed
@tiran
Address Greg's review comment
67b8d7f
@tiran
tiran requested a review from gpshead March 17, 2022 11:08
@tiran tiran added awaiting core review and removed awaiting changes labels Mar 17, 2022
gpshead
gpshead reviewed Mar 17, 2022
View reviewed changes
Comment thread Lib/test/test_hashlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
Write file once
8843102
gpshead
gpshead approved these changes Mar 21, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 21, 2022
@gpshead gpshead added the type-feature A feature request or enhancement label Mar 21, 2022
gpshead
gpshead reviewed Mar 21, 2022
View reviewed changes
Comment thread Lib/test/test_hashlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
Remove inner try/finally
689e5ec
@tiran
tiran requested a review from gpshead March 22, 2022 07:45
gpshead
gpshead approved these changes Mar 22, 2022
View reviewed changes
@tiran tiran added the 🤖 automerge label Mar 22, 2022
@miss-islington
miss-islington merged commit 4f97d64 into python:main Mar 22, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 22, 2022
@markshannon

markshannon commented Mar 22, 2022

Copy link
Copy Markdown
Member

This may have broken the buildbots.
https://buildbot.python.org/all/#/builders/713/builds/452
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Mar 22, 2022

Copy link
Copy Markdown
Member Author

This may have broken the buildbots. buildbot.python.org/all/#/builders/713/builds/452

FIPS ... let's see if GH-32046 solves the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran deleted the bpo-45150-file-digest branch March 22, 2022 13:24
@tiran tiran mentioned this pull request Apr 21, 2022
bpo-45150: add a simple file_digest helper #28252
Closed
@tarekziade tarekziade mannequin mentioned this pull request Aug 13, 2022
Add a file_digest() function in hashlib #89313
Closed
musashay23

This comment was marked as spam.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
+1 more reviewer
@musashay23 musashay23 musashay23 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tiran @bedevere-bot @markshannon @gpshead @musashay23 @the-knights-who-say-ni @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.