GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43224: Add TypeVarTuple.__name__ by JelleZijlstra · Pull Request #31954 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I noticed that TypeVar and ParamSpec put their name in a __name__
attribute, but TypeVarTuple doesn't. Let's be consistent.

https://bugs.python.org/issue43224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
bpo-43224: Add TypeVarTuple.__name__
aac15f8 
I noticed that TypeVar and ParamSpec put their name in a __name__
attribute, but TypeVarTuple doesn't. Let's be consistent.
@JelleZijlstra
JelleZijlstra requested review from Fidget-Spinner and gvanrossum as code owners March 17, 2022 04:11
@bedevere-bot bedevere-bot added the awaiting core review label Mar 17, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2022
@JelleZijlstra JelleZijlstra added the skip news label Mar 17, 2022
@JelleZijlstra

JelleZijlstra commented Mar 17, 2022

Copy link
Copy Markdown
Member Author

cc @mrahtz. Skipping news because we never released the previous version.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request Mar 17, 2022
Add typing.TypeVarTuple, Unpack, assert_type python/typeshed#7501
Merged
@JelleZijlstra
remove duplicate test
da0ca6d
JelleZijlstra
JelleZijlstra commented Mar 17, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py
self.assertEqual(repr(Unpack[tuple[Unpack[Ts]]]), '*tuple[*Ts]')
self.assertEqual(repr(Unpack[Tuple[Unpack[Ts]]]), '*typing.Tuple[*Ts]')

def test_repr_is_correct(self):

@JelleZijlstra JelleZijlstra Mar 17, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this is the same as the function above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka
serhiy-storchaka approved these changes Mar 17, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 17, 2022
@JelleZijlstra
JelleZijlstra merged commit 3a2b895 into python:main Mar 18, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 18, 2022
@JelleZijlstra
JelleZijlstra deleted the tvtname branch March 18, 2022 17:56
@mrahtz

mrahtz commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

Thanks Jelle!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mrahtz mrahtz mannequin mentioned this pull request Apr 11, 2022
Add support for PEP 646 #87390
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @mrahtz @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.