GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix whitespace error in setup.py by erlend-aasland · Pull Request #31960 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Fix whitespace error in setup.py
814d618
@bedevere-bot bedevere-bot added the awaiting review label Mar 17, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2022
@erlend-aasland
erlend-aasland requested a review from JelleZijlstra March 17, 2022 11:58
@erlend-aasland erlend-aasland added skip issue skip news labels Mar 17, 2022
@erlend-aasland

erlend-aasland commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

Azure Pipelines fails the make patchcheck
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Mar 17, 2022

Copy link
Copy Markdown
Member

Looks like this was added by #29725 a few months ago, do you know why it wasn't causing issues before? Is it because patchcheck checks only changed files?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Mar 17, 2022

Copy link
Copy Markdown
Member

Yes, patchcheck only checks changed files. It was also broken until 3 days ago (#31708) so it was probably was broken for #29725.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 424dfc7 into python:main Mar 17, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Mar 17, 2022
@erlend-aasland
erlend-aasland deleted the patchcheck branch March 17, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @JelleZijlstra @hugovk @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.