GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Fix patchcheck by hugovk · Pull Request #31708 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Mar 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

patchcheck was erroring on the CI but not reporting as a failure. It wasn't not actually checking any files:

Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
0 files

Two fixes here:

  • Make errors noisy: report then non-zero exit
  • Fix the error: CI was in detached HEAD, need to git fetch origin so it has access to diff origin/main

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-bot bedevere-bot added the awaiting review label Mar 6, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 6, 2022
@hugovk hugovk added the DO-NOT-MERGE label Mar 6, 2022
@AlexWaygood AlexWaygood added skip issue skip news labels Mar 6, 2022
@hugovk
hugovk force-pushed the test-patchcheck branch 3 times, most recently from 97f9e1c to 363fb93 Compare March 6, 2022 19:46
@hugovk
git fetch origin to fix patchcheck
c7acdca
@hugovk
hugovk force-pushed the test-patchcheck branch from 363fb93 to be72990 Compare March 6, 2022 20:02
@hugovk
Exit on error
71a288d
@hugovk
hugovk force-pushed the test-patchcheck branch from be72990 to 71a288d Compare March 6, 2022 20:48
@hugovk hugovk changed the title TEMP debugging pathcheck CI: Fix patchcheck Mar 6, 2022
@hugovk
hugovk marked this pull request as ready for review March 6, 2022 21:27
@hugovk hugovk removed the DO-NOT-MERGE label Mar 6, 2022
JelleZijlstra
JelleZijlstra approved these changes Mar 6, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 6, 2022
@JelleZijlstra

JelleZijlstra commented Mar 6, 2022

Copy link
Copy Markdown
Member

https://dev.azure.com/Python/cpython/_build/results?buildId=98028&view=logs&j=256d7e09-002a-52d7-8661-29ee3960640e&t=3d7276d3-4e8d-5309-55ad-fb0b172d9925 looks good
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Mar 6, 2022
View reviewed changes
raghavthind2005
raghavthind2005 approved these changes Mar 14, 2022
View reviewed changes
@asvetlov
asvetlov merged commit 23abae6 into python:main Mar 14, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 14, 2022
@asvetlov

asvetlov commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Thanks!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the test-patchcheck branch March 14, 2022 13:32
@hugovk hugovk mentioned this pull request Mar 14, 2022
Check for whitespace in CI python/core-workflow#429
Closed
carljm pushed a commit to carljm/cpython that referenced this pull request Mar 14, 2022
Carl Meyer
Merge branch 'main' into dictwatch
d22463b 
* main: (94 commits)
  Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879)
  bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548)
  git ignore Lib/site-packages (pythonGH-31862)
  bpo-31415: importtime was made by Inada Naoki (pythonGH-31875)
  bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813)
  bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812)
  bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814)
  bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866)
  bpo-40280: select: Use NULL for empty fdset (pythonGH-31865)
  CI: Fix patchcheck (pythonGH-31708)
  bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835)
  bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837)
  bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816)
  bpo-47003: Cleanup _overlapped module (pythonGH-31848)
  bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854)
  bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)
  bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819)
  bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455)
  bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838)
  bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525)
  ...
@hugovk hugovk mentioned this pull request Mar 17, 2022
Fix whitespace error in setup.py #31960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
+1 more reviewer
@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@hugovk @JelleZijlstra @asvetlov @erlend-aasland @raghavthind2005 @the-knights-who-say-ni @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.