GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects by ericsnowcurrently · Pull Request #32061 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed in the repo). However, building $(PYTHON_FOR_FREEZE) fails if one of its source files had a global object added or removed, without generate-global-objects.py running first. So make regen-global-objects would sometimes fail.

We solve this by running generate-global-objects.py before and after regen-deepfreeze. To speed things up and cut down on noise, we also avoid updating the global objects files if there are no changes.

https://bugs.python.org/issue46712

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits March 22, 2022 16:35
@ericsnowcurrently
Do not write to the file unless there are changes.
62e329d
@ericsnowcurrently
Run regen-deepfreeze manually instead of as a dependency.
32f618c
@ericsnowcurrently
Add a docstring.
9e3be69
@bedevere-bot bedevere-bot added the awaiting core review label Mar 22, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 22, 2022
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 22, 2022
@ericsnowcurrently
Hide the comments.
e9010c0
@ericsnowcurrently
ericsnowcurrently merged commit febf54b into python:main Mar 23, 2022
@ericsnowcurrently
ericsnowcurrently deleted the bpo-46712-fix-regen-global-objects branch March 23, 2022 15:55
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 23, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 28, 2022
bpo-47146: Eliminate a Race Between make regen-deepfreeze and make regen-global-objects #32162
Merged
ericsnowcurrently added a commit that referenced this pull request Mar 28, 2022
@ericsnowcurrently
bpo-47146: Eliminate a race between make regen-deepfreeze and make re…
4c116f7 
…gen-global-objects. (gh-32162)

The race likely originated with gh-32061.

https://bugs.python.org/issue47146
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 10, 2022
Share global string identifiers in deepfreeze #90868
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.