GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46712: share more global strings in deepfreeze by kumaraditya303 · Pull Request #32152 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Mar 28, 2022 •
edited by ericsnowcurrently
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46712

(#90868)

@kumaraditya303 ➜ /workspaces/cpython (more-strings) $ cat Python/deepfreeze/deepfreeze.c | grep _Py_STR | wc -l
159

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
share global strings in deepfreeze
5906d65
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner March 28, 2022 09:14
@bedevere-bot bedevere-bot added the awaiting review label Mar 28, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 28, 2022
@kumaraditya303
fix compile.c
fc87870
gvanrossum
gvanrossum reviewed Mar 28, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepfreeze.py changes are okay, but I need @ericsnowcurrently to review the rest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
gvanrossum requested review from ericsnowcurrently and removed request for markshannon March 28, 2022 15:52
@gvanrossum gvanrossum added the skip news label Mar 28, 2022
@kumaraditya303

kumaraditya303 commented Apr 14, 2022

Copy link
Copy Markdown
Contributor Author

@gvanrossum Any update on this? Is this in Eric's review queue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Apr 14, 2022

Copy link
Copy Markdown
Member

@ericsnowcurrently Please review.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Merge branch 'main' into more-strings
2409fc9
ericsnowcurrently
ericsnowcurrently approved these changes Apr 19, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 19, 2022
@ericsnowcurrently
ericsnowcurrently merged commit ab0d35d into python:main Apr 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 19, 2022
@ericsnowcurrently

ericsnowcurrently commented Apr 19, 2022

Copy link
Copy Markdown
Member

Thanks, @kumaraditya303! Sorry for the delay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the more-strings branch September 26, 2022 11:03
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 10, 2022
Share global string identifiers in deepfreeze #90868
Closed
This was referenced Apr 26, 2023
Use char and latin1 singletons in deepfreeze #103875
Closed
gh-103875: Use char and latin1 singletons in deepfreeze. #103876
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @gvanrossum @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.