GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103875: Use char and latin1 singletons in deepfreeze. by oraluben · Pull Request #103876 · python/cpython

Conversation

@oraluben

@oraluben oraluben commented Apr 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This change allow deepfreeze to use char and latin1 singletons.

Related change: #32152

  • Issue: Use char and latin1 singletons in deepfreeze #103875

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oraluben
Use char and latin1 singletons in deepfreeze.
4ae74ca
@bedevere-bot

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Use char and latin1 singletons in deepfreeze #103875
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 26, 2023
@oraluben

oraluben commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Hi @kumaraditya303 @ericsnowcurrently , would you mind to take a look at this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Apr 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 26, 2023
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) April 26, 2023 11:19
@kumaraditya303
Merge branch 'main' into deep-freeze-use-char-singleton
5ec6e19
@kumaraditya303 kumaraditya303 added the skip news label Apr 26, 2023
@python python deleted a comment from bedevere-bot Apr 26, 2023
@kumaraditya303
kumaraditya303 merged commit 214e568 into python:main Apr 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 26, 2023
@oraluben
oraluben deleted the deep-freeze-use-char-singleton branch April 26, 2023 11:50
oraluben added a commit to oraluben/pycds that referenced this pull request Apr 26, 2023
@oraluben
test that static strings (`_PyRuntime.static_objects.singletons.strin…
dfb1696 
…gs`, not strings allocated by deepfreeze) are reused.

Ref: python/cpython#103876
itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
@oraluben @itamaro
pythongh-103875: Use ascii and latin1 singletons in deepfreeze (pytho…
caaa0ad 
…n#103876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@oraluben @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.