GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90005: Port _ctypes to PY_STDLIB_MOD by tiran · Pull Request #32229 · python/cpython

Conversation

@tiran

@tiran tiran commented Apr 1, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue45847

  • Issue: Port module setup to PY_STDLIB_MOD() macro and addext() #90005

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tiran
tiran requested review from erlend-aasland, ned-deily and ronaldoussoren April 1, 2022 10:27
@bedevere-bot bedevere-bot added the awaiting core review label Apr 1, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 1, 2022
@tiran
tiran force-pushed the bpo-45847-ctypes2 branch 3 times, most recently from 07a2d53 to 48b7e12 Compare April 1, 2022 12:13
@arhadthedev

arhadthedev commented Apr 1, 2022

Copy link
Copy Markdown
Member

Is is a harbinger of finally devendored libffi? Currently, CPython ships 1.20 (1998) while Debian LTS supplies 3.2.1 (2014).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45847-ctypes2 branch from 48b7e12 to 1fa02d9 Compare April 1, 2022 12:25
@tiran

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

libffi was de-vendored in 3.7 (Linux, BSD) and 3.8 (Windows). We only keep a copy for macos around.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45847-ctypes2 branch from 4bd87da to cc5cb24 Compare April 1, 2022 12:40
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022
@bedevere-bot

bedevere-bot commented Apr 1, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit cc5cb24a3c148b044e5bc2cb606b8a612e6f0440 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022
@tiran

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

ctypes tests are failing on ARM64 macOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45847-ctypes2 branch from cc5cb24 to 54e6b11 Compare April 1, 2022 13:27
@tiran

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

I have no clue how the SDK stuff works on macOS. In order to land the PR I would need some assistance from @ned-deily or @ronaldoussoren . Or can we drop the SDK and use system-ffi on all system?

erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022
@bedevere-bot

bedevere-bot commented Apr 1, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 54e6b1122be7ab28dc0456516cc4d3f81fc0df7e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022
@ronaldoussoren

ronaldoussoren commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

I'll try to look at the PR over the weekend.

As a general statement I'd prefer to use the system install of libffi on macOS because Apple includes some magic in its version to ensure libffi closures work properly with their code signature system (in particular some magic to ensure that you don't need the "JIT" entitlement to use closures).

tiran reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the bpo-45847-ctypes2 branch from 54e6b11 to 53607e3 Compare April 2, 2022 23:12
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 2, 2022
@bedevere-bot

bedevere-bot commented Apr 2, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 53607e36d3dd2446103a5d9175b8d3ee1e271e08 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 2, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022
@bedevere-bot

bedevere-bot commented Apr 3, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit e4ab8cf4c4d2bf9156f0551d8df68299ef153295 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022
@tiran
tiran marked this pull request as ready for review April 4, 2022 09:31
tiran added 11 commits June 26, 2022 09:58
@tiran
Port macOS specific ctypes code
03e630c
@tiran
ctypes build no longer depends on other modules
31a744b
@tiran
AS_VAR_APPEND needs explicit space
5fabd8b
@tiran
Detect macOS SDKROOT with xcrun
7932611
@tiran
Fix CFLAGS
0b679b6
@tiran
Use system-ffi by default on macOS
6cafbfe
@tiran
Use PY_CHECK_FUNC to look for ffi functions
0f1162a
@tiran
SDK libffi
d6cd64a
@tiran
Check for have_libffi
4914c9e
@tiran
Remove special case for hpux
6849e30
@tiran
rename news entry
d854d7f
@tiran
tiran force-pushed the bpo-45847-ctypes2 branch from 771527a to d854d7f Compare June 26, 2022 08:00
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 26, 2022
@bedevere-bot

bedevere-bot commented Jun 26, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit d854d7f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 26, 2022
@tiran

tiran commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

@ned-deily @ronaldoussoren I would like to merge this PR rather sooner than later into main. It is required to test ctypes on wasm32-emscripten and will allow us to remove setup.py. Tests are passing on macOS.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland reviewed Jun 26, 2022
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Jun 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 26, 2022
@tiran @erlend-aasland
Update configure.ac
fecba2a
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@tiran tiran added the 🤖 automerge label Jun 26, 2022
@miss-islington

miss-islington commented Jun 26, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit bb8b931 into python:main Jun 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2022
@tiran
tiran deleted the bpo-45847-ctypes2 branch June 26, 2022 11:14
@eli-schwartz eli-schwartz mentioned this pull request Jun 19, 2024
Failing configure tests due to missing space #120671
Closed
@allsey87 allsey87 mentioned this pull request Jun 21, 2024
gh-120671: Fix as_fn_append CFLAGS #120822
Merged
@hoodmane hoodmane mentioned this pull request Jun 15, 2026
gh-151422: Don't link libffi into _ctypes_test.so #151423
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren
@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@tiran @arhadthedev @bedevere-bot @ronaldoussoren @erlend-aasland @kulikjak @ned-deily @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.