GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-44800: Document internal frame naming conventions" by markshannon · Pull Request #32301 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Apr 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reverts #32281 as it is both misleading in general and incorrect in detail.

General:
Listing each field, and stating its name, is pointless and just gets in the way of reading the code which contains the same information and is guaranteed unambiguous and up to date.
The language is vague, and is misleading when describing why there are two structs, PyInterpeterFrame, and PyFrameObject and what their roles are.

Detail:
There is no f_state field (and f_lasti will be replaced imminently).

https://bugs.python.org/issue44800

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Revert "bpo-44800: Document internal frame naming conventions (GH-32281…
fc00396 
…)"

This reverts commit 124227c.
@bedevere-bot bedevere-bot added the awaiting core review label Apr 4, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 4, 2022
@markshannon markshannon added the skip news label Apr 4, 2022
@markshannon
markshannon merged commit 8a349eb into main Apr 4, 2022
@markshannon
markshannon deleted the revert-32281-bpo-44800-document-status-quo branch April 4, 2022 14:09
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 4, 2022
@bedevere-bot

bedevere-bot commented Apr 4, 2022

Copy link
Copy Markdown

@markshannon: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

See #32304
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ncoghlan ncoghlan mentioned this pull request Apr 16, 2022
Code readability: rename InterpreterFrame to _Py_framedata #88963
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.