GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44800: Document internal frame naming conventions by ncoghlan · Pull Request #32281 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Apr 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The fact interpreter frames were split out from full frame objects
rather than always being part of the eval loop implementation means
that it's tricky to infer the expected naming conventions simply
from looking at the code.

Documenting the de facto conventions in pycore_frame.h means future
readers of the code will have a clear explanation of the rationale
for those conventions (i.e. minimising non-functional code churn).

Closes bpo-44800

https://bugs.python.org/issue44800

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan
bpo-44800: Document internal frame naming conventions
a01989e
The fact interpreter frames were split out from full frame objects
rather than always being part of the eval loop implementation means
that it's tricky to infer the expected naming conventions simply
from looking at the code.

Documenting the de facto conventions in pycore_frame.h means future
readers of the code will have a clear explanation of the rationale
for those conventions (i.e. minimising non-functional code churn).
@bedevere-bot bedevere-bot added the awaiting core review label Apr 3, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 3, 2022
@ncoghlan ncoghlan added the skip news label Apr 3, 2022
@ncoghlan ncoghlan mentioned this pull request Apr 3, 2022
bpo-44800: unobtrusively rename _PyInterpreterFrame to _Py_frame #32024
Closed
@ncoghlan
ncoghlan merged commit 124227c into python:main Apr 3, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 3, 2022
markshannon added a commit that referenced this pull request Apr 4, 2022
@markshannon
Revert "bpo-44800: Document internal frame naming conventions (GH-32281…
fc00396
…)"

This reverts commit 124227c.
@markshannon

markshannon commented Apr 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@ncoghlan Please don't merge changes without review.

This change is both misleading in general and incorrect in detail, as I would have pointed out had you waited for a review rather than merging immediately.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon markshannon mentioned this pull request Apr 4, 2022
Revert "bpo-44800: Document internal frame naming conventions" #32301
Merged
markshannon added a commit that referenced this pull request Apr 4, 2022
@markshannon
Revert "bpo-44800: Document internal frame naming conventions (GH-32281…
8a349eb
…)" (#32301)

This reverts commit 124227c.
@markshannon

markshannon commented Apr 4, 2022

Copy link
Copy Markdown
Member

See #32304

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan ncoghlan mentioned this pull request Apr 16, 2022
Code readability: rename InterpreterFrame to _Py_framedata #88963
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ncoghlan @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.