GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix whitespace/indentation format in test_sys by Fidget-Spinner · Pull Request #32369 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Apr 6, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

make patchcheck is failing after editing test_sys in GH-31936 due to this indent.

Automerge-Triggered-By: GH:Fidget-Spinner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Fix whitespace/indentation issues in test_sys
e61e5f7
@bedevere-bot bedevere-bot added the awaiting core review label Apr 6, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 6, 2022
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 6, 2022
@Fidget-Spinner Fidget-Spinner added skip issue skip news needs backport to 3.9 labels Apr 6, 2022
@Fidget-Spinner Fidget-Spinner changed the title Fix whitespace/indentation issue in test_sys Fix whitespace/indentation format in test_sys Apr 6, 2022
@Fidget-Spinner Fidget-Spinner added the 🤖 automerge label Apr 6, 2022
@Fidget-Spinner
Fidget-Spinner merged commit da92240 into python:main Apr 6, 2022
@miss-islington

miss-islington commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 6, 2022
@miss-islington

miss-islington commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Sorry, @Fidget-Spinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da922409ac3e65c6bf2911401c7dfdf8ee6e0036 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned Fidget-Spinner Apr 6, 2022
@miss-islington

miss-islington commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Sorry @Fidget-Spinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da922409ac3e65c6bf2911401c7dfdf8ee6e0036 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner Fidget-Spinner added needs backport to 3.10 and removed needs backport to 3.9 labels Apr 6, 2022
@miss-islington

miss-islington commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Sorry, @Fidget-Spinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da922409ac3e65c6bf2911401c7dfdf8ee6e0036 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner deleted the fix_test_sys_whitespace branch April 6, 2022 15:42
@Fidget-Spinner Fidget-Spinner removed the needs backport to 3.10 label Apr 6, 2022
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Apr 6, 2022
@Fidget-Spinner
Fix whitespace/indentation issues in test_sys (pythonGH-32369)
cd8def4
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Apr 6, 2022
@Fidget-Spinner
Fix whitespace/indentation issues in test_sys (pythonGH-32369)
35ee8c1
Fidget-Spinner added a commit that referenced this pull request Apr 6, 2022
@Fidget-Spinner
Fix whitespace/indentation issues in test_sys (GH-32369) (GH-32373)
1ab5351 
(cherry picked from commit da92240)
Fidget-Spinner added a commit that referenced this pull request Apr 20, 2022
@Fidget-Spinner
Fix whitespace/indentation issues in test_sys (GH-32369) (GH-32372)
942ea19
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@Fidget-Spinner @hello-adam
Fix whitespace/indentation issues in test_sys (pythonGH-32369) (pytho…
a079d07 
…nGH-32373)

(cherry picked from commit da92240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Fidget-Spinner Fidget-Spinner

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Fidget-Spinner @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.