GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed a handful of typos by alex · Pull Request #343 · python/cpython

Conversation

@alex

@alex alex commented Feb 27, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alex
Fixed a handful of typos
3bd2234
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 27, 2017
berkerpeksag
berkerpeksag reviewed Feb 27, 2017
View reviewed changes
Comment thread Doc/library/ssl.rst Outdated

Usually, :class:`SSLSocket` are not created directly, but using the
the :meth:`SSLContext.wrap_socket` method.
Usually, :class:`SSLSocket` are not created directly, but using the :meth:`SSLContext.wrap_socket` method.

@berkerpeksag berkerpeksag Feb 27, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a bit long. It would be nice to wrap it at 80 or so chars.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@alex alex Feb 27, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alex
linewrap
7d88d2f
marco-buttu
marco-buttu approved these changes Feb 27, 2017
View reviewed changes

@marco-buttu marco-buttu left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
berkerpeksag
berkerpeksag approved these changes Feb 27, 2017
View reviewed changes
@Mariatta

Mariatta commented Feb 27, 2017

Copy link
Copy Markdown
Member

So I'm not sure how to apply the labels here lol

Doc/library/email.compat32-message.rst -> needs backport to 3.6
Doc/library/email.message.rst -> needs backport to 3.6
Doc/library/idle.rst -> needs backport to 2.7, 3.5, 3.6
Doc/library/ssl.rst -> needs backport to 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added the needs backport to 3.6 label Feb 27, 2017
@berkerpeksag

berkerpeksag commented Feb 27, 2017

Copy link
Copy Markdown
Member

I'd say don't bother to backport this to 2.7 and 3.5 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Feb 27, 2017

Copy link
Copy Markdown
Member

ok. then everything else LGTM :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta
Mariatta approved these changes Feb 27, 2017
View reviewed changes
@Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 27, 2017
@Mariatta
Mariatta merged commit 1cf2a80 into python:master Mar 1, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 1, 2017
@alex @Mariatta
Fixed a handful of typos (pythonGH-343)
5272f73 
(cherry picked from commit 1cf2a80)
@alex
alex deleted the typos branch March 1, 2017 03:31
@Mariatta Mariatta removed the needs backport to 3.6 label Mar 1, 2017
Mariatta added a commit that referenced this pull request Mar 1, 2017
@Mariatta
Fixed a handful of typos (GH-343) (GH-364)
1b93ed4 
(cherry picked from commit 1cf2a80)
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Revert to celery 4.4.2 (#343)
4e89023 
Fix #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@Mariatta Mariatta Mariatta approved these changes
+1 more reviewer
@marco-buttu marco-buttu marco-buttu approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@alex @Mariatta @berkerpeksag @marco-buttu @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.