GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" by ericsnowcurrently · Pull Request #3565 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Sep 14, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR #1638, for bpo-28411, causes problems in some (very) edge cases. Until that gets sorted out, we're reverting the merge. PR #3506, a fix on top of #1638, is also getting reverted.

https://bugs.python.org/issue31404

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits September 14, 2017 06:11
@ericsnowcurrently
Revert "bpo-30860: Fix a refleak. (python#3506)"
e532e34 
This reverts commit 8728018.
@ericsnowcurrently
Revert "bpo-28411: Remove "modules" field from Py_InterpreterState. (p…
9e05a48 
…ython#1638)"

This reverts commit 86b7afd.
@ericsnowcurrently
ericsnowcurrently requested a review from a team September 14, 2017 06:23
@bedevere-bot bedevere-bot added the awaiting merge label Sep 14, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 14, 2017
@ericsnowcurrently
ericsnowcurrently merged commit 93c92f7 into python:master Sep 14, 2017
@ericsnowcurrently
ericsnowcurrently deleted the revert-remove-modules-from-interpreter-state branch September 14, 2017 06:46
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 14, 2017
bpo-30860: Fix a refleak. #3567
Merged
ericsnowcurrently added a commit that referenced this pull request Sep 14, 2017
@ericsnowcurrently
bpo-30860: Fix a refleak. (#3567)
dae0276 
Resolves bpo-31420.

(This was accidentally reverted when in #3565.)
@Mariatta Mariatta removed the awaiting merge label Oct 8, 2017
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] Eliminate PyInterpreterState.modules. #72597
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @Mariatta @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.