GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29666: correct documentation for enum.html by kartikanand · Pull Request #358 · python/cpython

Conversation

@kartikanand

@kartikanand kartikanand commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

Correct documentation for enum.html by adding the fourth missing type Flag and correcting the wrongly mentioned IntFlag

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kartikanand
correct documentation for enum.html
082586c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2017
ethanfurman
ethanfurman approved these changes Feb 28, 2017
View reviewed changes
DimitrisJim
DimitrisJim approved these changes Feb 28, 2017
View reviewed changes
@vstinner
vstinner merged commit 6265842 into python:master Feb 28, 2017
@vstinner vstinner added docs Documentation in the Doc dir needs backport to 3.6 labels Feb 28, 2017
@vstinner

vstinner commented Feb 28, 2017

Copy link
Copy Markdown
Member

Thanks!

@kartikanand : this change needs to be backported, can you try to cherry-pick the change to the 3.6 branch using "git cherry-pick -x "?
https://docs.python.org/3.6/library/enum.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 1, 2017
@kartikanand @Mariatta
correct documentation for enum.html (python#358)
2f20e51 
(cherry picked from commit 6265842)
@Mariatta Mariatta removed the needs backport to 3.6 label Mar 1, 2017
Mariatta added a commit that referenced this pull request Mar 1, 2017
@Mariatta
correct documentation for enum.html (GH-358) (GH-367)
8458b2b 
(cherry picked from commit 6265842)
@kartikanand
kartikanand deleted the fix-issue-29666 branch March 1, 2017 07:20
@vstinner vstinner added the needs backport to 3.6 label Mar 2, 2017
@vstinner

vstinner commented Mar 2, 2017

Copy link
Copy Markdown
Member

IHMO it's worth it to backport the change to Python 3.6. @kartikanand can you please try to cherry-pick the change to Python 3.6 using "git cherry-pick -x " ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kartikanand

kartikanand commented Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

@Haypo It seems @Mariatta has already merged it in 3.6 - #367
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag removed the needs backport to 3.6 label Mar 2, 2017
@vstinner

vstinner commented Mar 2, 2017

Copy link
Copy Markdown
Member

@Haypo It seems @Mariatta has already merged it in 3.6 - #367

Oh right, @Mariatta just forgot to mention the bpo number in its PR and commit message. I updated the issue, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 2, 2017

Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag removed the needs backport to 3.6 label an hour ago

Why did you remove the label? Are you using this label to check if the backport was done or not? I prefer to keep the label even if the change was already backported to 3.6.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Mar 2, 2017

Copy link
Copy Markdown
Member

Are you using this label to check if the backport was done or not?

Yes, this has been used to track backport statuses for a while. I suggest opening an issue at python/core-workflow to discuss this :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Use Python 3.7.8 (#359)
5f46257 
Closes #358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes
+1 more reviewer
@DimitrisJim DimitrisJim DimitrisJim approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@kartikanand @vstinner @berkerpeksag @ethanfurman @DimitrisJim @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.