GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [DO NOT MERGE] Test no mention-bot by dstufft · Pull Request #368 · python/cpython

Conversation

@dstufft

@dstufft dstufft commented Mar 1, 2017

Copy link
Copy Markdown
Member

Test to ensure that the mention-bot is not mentioning on 3.6 any longer by re-submitting #364. Sorry if someone gets mentioned again!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dstufft
Test no mention-bot
360dc07
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 1, 2017
@dstufft dstufft mentioned this pull request Mar 1, 2017
Add the mention bot? python/core-workflow#32
Closed
@dstufft dstufft closed this Mar 1, 2017
@dstufft
dstufft deleted the test branch March 1, 2017 04:28
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview @Mariatta
Bump pytest from 5.4.3 to 6.0.1 (#368)
d9ba7af
Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.4.3 to 6.0.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@5.4.3...6.0.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Mariatta <[email protected]>
SonicField added a commit to SonicField/cpython that referenced this pull request May 13, 2026
@SonicField
Phase 5.B c14-followup-A: static_assert guard for jit::FrameHeader si…
1fc473a
…zeof

Closes c14 latent silent-break gap per supervisor 00:51:18Z (A) +
pythia python#368 missing-validation flag.

c14 (0703dba) phx_frame_header_size hardcodes sizeof(void*) for the
FrameHeader argument to jit_frame_header_size, matching C++ frameHeaderSize
semantics (frame_header.h:67). The hardcoded value is documented as "On
3.12+, FrameHeader = union { PyFunctionObject*; uintptr_t rtfs; } =
sizeof(void*)" — comment-derived, NOT static_asserted.

If the FrameHeader union grows in a future Python version (or even on
3.12.X minor revisions adding fields), the hardcoded sizeof(void*)
silently produces wrong offsets at runtime, re-creating the c14 SIGSEGV
class with no compile-time signal.

This commit adds a static_assert guard in hir_instr_c_verify.cpp:

  #if PY_VERSION_HEX >= 0x030C0000
  static_assert(sizeof(jit::FrameHeader) == sizeof(void*), "...");
  #endif

Files:
  M Python/jit/hir/hir_instr_c_verify.cpp  (+15 LOC: include + 5-line
    static_assert with explanatory comment)

Net delta: +15 LOC.

Defensive-infra-class commit per docs/methodology/synthetic_falsifier_at_gate.md
(1546c43). Synthetic falsifier OPTIONAL given trivial scope (5-LOC
static_assert + include) per supervisor 00:51:18Z (A) — would-be falsifier
test (intentionally redefining FrameHeader to 16 bytes; verifying static
assert FIRES) is symbolic since the FrameHeader struct is defined upstream.

PRE-COMMIT BUILD VERIFIED via pre-commit hook a2e8808 — hook
re-globs .cpp file via cmake configure, compiles with new static_assert,
PASS = current FrameHeader is sizeof(void*) on this build target.
SonicField added a commit to SonicField/cpython that referenced this pull request May 13, 2026
@SonicField
docs/methodology: pre-port-audit-checklist (3-category cascade-audit)
0efc0e1
Authored per supervisor 00:51:18Z (B) + pythia python#368 audit-completeness
gap. Closes the chat→structural gap for the cascade-audit-3-category
discipline (feedback_cascade_audit_3category) by codifying the explicit
checklist into the corpus.

Files:
  NEW docs/methodology/pre-port-audit-checklist.md  (+118 LOC)

Specifies:
- Motivation (c14 a6500318e0 SIGSEGV: audit cited only sizeof, missed
  offsetof + literal-offset categories; +8-byte offset corruption from
  frame_asm_c_frame_header_size +sizeof(void*) asymmetry vs C++
  frameHeaderSize)
- 3 categories explicit:
  (a) Sizeof equivalence (per touched C++ struct/class)
  (b) Offsetof equivalence per accessed field (NOT optional even if
      sizeof matches — empty-base-optimization can shift offsets
      symmetrically)
  (c) Hardcoded literal-offset equivalents (verify C-side substitute
      has same semantics as C++ original; cite both file:line; identify
      asymmetries: asm-helper vs LIR-generation, version conditionals,
      arithmetic adjustments)
- Pre-audit procedure (4 steps: enumerate a, enumerate b, enumerate c,
  compose audit post)
- Pre-audit example using c14 retrospective (what the audit SHOULD have
  said — calibration anchor)
- Enforcement chain (author cite + gatekeeper APPROVE checklist + medic
  flag + supervisor dispose)
- Out-of-scope (routine, docs, test, single-language refactors)
- Non-coverage caveat (catches structural layout, NOT algorithmic
  differences / side effects / threading)
- Self-falsifying disclaimer (calibration: any audit citing 3 categories
  at this detail level that still misses c14-class bug = checklist
  incomplete, not author failure)

NOT a v2.x amendment per moratorium (D-1778554524) — operational
discipline / methodology document. Companion to
synthetic_falsifier_at_gate.md (1546c43).

PRE-COMMIT BUILD: doc-only; pre-commit hook docs-path-skip per
a2e8808 self-config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dstufft @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.