GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31572: Get rid of using _PyObject_HasAttrId() in pickle. by serhiy-storchaka · Pull Request #3729 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 24, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue31572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-31572: Get rid of using _PyObject_HasAttrId() in pickle.
778c0d7
@serhiy-storchaka serhiy-storchaka added skip news type-bug An unexpected behavior, bug, or error labels Sep 24, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 24, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Sep 24, 2017
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.6 label Oct 22, 2017
@serhiy-storchaka
serhiy-storchaka merged commit 04e36af into python:master Oct 22, 2017
@miss-islington

miss-islington commented Oct 22, 2017

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 22, 2017
@serhiy-storchaka
serhiy-storchaka deleted the pickle-no-hasattr branch October 22, 2017 18:31
@miss-islington

miss-islington commented Oct 22, 2017

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 04e36af9b88cd5e80fc818e51d46f07252a2ff3f 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 23, 2017
@serhiy-storchaka
[3.6] bpo-31572: Get rid of using _PyObject_HasAttrId() in pickle. (p…
2ad2a49 
…ythonGH-3729).

(cherry picked from commit 04e36af)
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Oct 23, 2017
@bedevere-bot

bedevere-bot commented Oct 23, 2017

Copy link
Copy Markdown

GH-4081 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Oct 23, 2017
@serhiy-storchaka
[3.6] bpo-31572: Get rid of using _PyObject_HasAttrId() in pickle. (G…
77af0a3 
…H-3729). (#4081)

(cherry picked from commit 04e36af)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Avoid suppressing all exceptions in PyObject_HasAttr() #75753
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.