GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [2.7] bpo-31285: fix an assertion failure and a SystemError in warnings.warn_explicit (GH-3219) by orenmn · Pull Request #3805 · python/cpython

Conversation

@orenmn

@orenmn orenmn commented Sep 28, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a backport of #3219 , but actually also a backport of #3803 , which is a cleanup after #3219 .

Also, i removed the test that verifies that the assertion failure is no more, because in 2.7, the code assumes that the value returned by splitlines() is a string, and uses it without asserting it is a string, in such a way that causing some error (for testing purposes) is not simple (at least i didn't find a simple way).
ISTM that the first test is good enough to verify that the splitlines() attribute is ignored, and PyUnicode_Splitlines() is used directly.

https://bugs.python.org/issue31285

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orenmn
init commit
2dd0cc0
@bedevere-bot bedevere-bot mentioned this pull request Sep 28, 2017
bpo-31285: fix an assertion failure and a SystemError in warnings.warn_explicit #3219
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 28, 2017
@bedevere-bot bedevere-bot added the awaiting review label Sep 28, 2017
@orenmn

orenmn commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

Serhiy and I agreed on another solution (https://bugs.python.org/issue31285#msg303308), so i would open another PR, this time with a sensible branch name.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orenmn orenmn closed this Sep 29, 2017
@orenmn
orenmn deleted the bpo31478-backport27 branch September 29, 2017 14:35
@Mariatta Mariatta removed the awaiting review label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@orenmn @Mariatta @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.