GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31285: Remove splitlines identifier from Python/_warnings.c (forgot to remove it in #3219) by orenmn · Pull Request #3803 · python/cpython

Conversation

@orenmn

@orenmn orenmn commented Sep 28, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#3219 removed the only use of the splitlines identifier in Python/_warnings.c, so it should be completely removed.

https://bugs.python.org/issue31285

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orenmn
init commit
9458ab2
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 28, 2017
@bedevere-bot bedevere-bot added the awaiting review label Sep 28, 2017
@orenmn orenmn mentioned this pull request Sep 28, 2017
[2.7] bpo-31285: fix an assertion failure and a SystemError in warnings.warn_explicit (GH-3219) #3805
Closed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 skip news labels Sep 29, 2017
@serhiy-storchaka
serhiy-storchaka merged commit 8b4ff53 into python:master Sep 29, 2017
@miss-islington

miss-islington commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

Thanks @orenmn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 29, 2017

Copy link
Copy Markdown

GH-3829 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Sep 29, 2017
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2017
@orenmn @miss-islington
[3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (…
3c3e62c 
…pythonGH-3803)

(forgot to remove it in pythonGH-3219)
(cherry picked from commit 8b4ff53)
serhiy-storchaka pushed a commit that referenced this pull request Sep 29, 2017
@miss-islington @serhiy-storchaka
[3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (…
66c2b9f 
…GH-3803) (#3829)

(forgot to remove it in GH-3219)
(cherry picked from commit 8b4ff53)
@Mariatta Mariatta removed the awaiting review label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@orenmn @miss-islington @bedevere-bot @serhiy-storchaka @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.