GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (GH-3803) by miss-islington · Pull Request #3829 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 29, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(forgot to remove it in GH-3219)
(cherry picked from commit 8b4ff53)

https://bugs.python.org/issue31285

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@orenmn @miss-islington
[3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (…
3c3e62c 
…pythonGH-3803)

(forgot to remove it in pythonGH-3219)
(cherry picked from commit 8b4ff53)
@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 29, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Sep 29, 2017
@bedevere-bot bedevere-bot mentioned this pull request Sep 29, 2017
bpo-31285: Remove splitlines identifier from Python/_warnings.c (forgot to remove it in #3219) #3803
Merged
@bedevere-bot bedevere-bot added the awaiting review label Sep 29, 2017
@serhiy-storchaka serhiy-storchaka added the skip news label Sep 29, 2017
@miss-islington

miss-islington commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

@orenmn and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit 66c2b9f into python:3.6 Sep 29, 2017
@miss-islington

miss-islington commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, @serhiy-storchaka!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington deleted the backport-8b4ff53-3.6 branch September 29, 2017 19:26
@Mariatta Mariatta removed the awaiting review label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @the-knights-who-say-ni @serhiy-storchaka @Mariatta @bedevere-bot @orenmn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.