GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29703: asyncio: Fix creating new event loops in child processes. by 1st1 · Pull Request #404 · python/cpython

Conversation

@1st1

@1st1 1st1 commented Mar 2, 2017

Copy link
Copy Markdown
Member

Proxy issue for python/asyncio#497

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 2, 2017
@mention-bot

mention-bot commented Mar 2, 2017

Copy link
Copy Markdown

@1st1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @tiran, @serhiy-storchaka and @zware to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1

1st1 commented Mar 2, 2017

Copy link
Copy Markdown
Member Author

The PR is already reviewed by @fafhrd91.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Mar 2, 2017

Copy link
Copy Markdown
Member

Minor nit pick: The title is slightly confusing. To me a subprocess implies fork+exec. The fix is about fork, so 'child process' or 'forked child' is more descriptive.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1

1st1 commented Mar 2, 2017

Copy link
Copy Markdown
Member Author

@tiran It's not only about explicitly forked (with os.fork()) child processes, it's also about subprocesses created with multiprocessing, or even concurrent.futures.ProcessPoolExecutor. All in all I agree you wording is better, will update the commit/news message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1 1st1 changed the title bpo-29703: asyncio: Fix creating new event loops in subprocesses. bpo-29703: asyncio: Fix creating new event loops in child processes. Mar 2, 2017
Yury Selivanov
bpo-29703: asyncio: Fix creating new event loops in child processes.
34761bc
@1st1
1st1 force-pushed the bpo-29703 branch from 02d7ee3 to 34761bc Compare March 2, 2017 22:25
Yury Selivanov
Move news entry to the top
6ef54b0
@1st1 1st1 added needs backport to 3.5 labels Mar 2, 2017
@1st1

1st1 commented Mar 2, 2017

Copy link
Copy Markdown
Member Author

@tiran @Haypo Could you please approve this PR? This needs to go in 3.6.1 tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1
1st1 merged commit ba7e1f9 into python:master Mar 3, 2017
@1st1 1st1 mentioned this pull request Mar 3, 2017
bpo-29703: asyncio: Fix creating new event loops in child processes #410
Merged
1st1 added a commit to 1st1/cpython that referenced this pull request Mar 3, 2017
@1st1 Yury Selivanov
bpo-29703: asyncio: Fix creating new event loops in child processes. (p…
3f44fa5 
…ython#404)
@1st1 1st1 mentioned this pull request Mar 3, 2017
bpo-29703: asyncio: Fix creating new event loops in child processes. (#404) #411
Merged
1st1 added a commit to 1st1/cpython that referenced this pull request Mar 3, 2017
@1st1 Yury Selivanov
bpo-29703: asyncio: Fix creating new event loops in child processes. (p…
3483f98 
…ython#404)
1st1 added a commit that referenced this pull request Mar 3, 2017
@1st1
bpo-29703: asyncio: Fix creating new event loops in child processes. (#…
01e5230 
…404) (#410)
@1st1

1st1 commented Mar 3, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

See also 902e9c5, 80fbacc, 2ef08d3.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1st1 referenced this pull request Mar 3, 2017
Yury Selivanov
asyncio: Optimize _get_running_loop() to call getpid() only when ther…
902e9c5 
…e's a loop
@Mariatta Mariatta removed needs backport to 3.5 labels Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@1st1 @mention-bot @tiran @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.