GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32051: update multiprocessing doc by 1a1a11a · Pull Request #4469 · python/cpython

Conversation

@1a1a11a

@1a1a11a 1a1a11a commented Nov 19, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove name conflict under "Using a remove manager" section, the original usage of queue conflicts with module name queue.

https://bugs.python.org/issue32051

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 19, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Nov 19, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Nov 19, 2017
@1a1a11a 1a1a11a changed the title Issue 32051 update multiprocessing doc [issue 32051] update multiprocessing doc Nov 19, 2017
@1a1a11a 1a1a11a changed the title [issue 32051] update multiprocessing doc bpo-32051: update multiprocessing doc Nov 19, 2017
@1a1a11a

1a1a11a commented Nov 19, 2017

Copy link
Copy Markdown
Contributor Author

I have signed the CLA, waiting for system to pass and re-check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag
berkerpeksag requested changes Nov 24, 2017
View reviewed changes
Comment thread Doc/library/multiprocessing.rst Outdated

@berkerpeksag berkerpeksag Nov 24, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think multiprocessing.Queue is needed here. We don't communicate between different processes in the same machine so using queue.Queue is OK.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@1a1a11a 1a1a11a Nov 24, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the comment, what should I do now? Should I make the change and submit a new pull request?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@berkerpeksag berkerpeksag Nov 24, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to submit a new pull request. You can make the requested changes and push to your existing branch. In your case, that would be the master branch.

You can follow the guide at https://devguide.python.org/pullrequest/#step-by-step-guide for your future pull requests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Documentation/2017-11-19-13-34-28.bpo-32051.KBMEYJ.rst Outdated

@berkerpeksag berkerpeksag Nov 24, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add a NEWS entry for trivial documentation changes. Please delete this file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting review label Nov 24, 2017
@bedevere-bot

bedevere-bot commented Nov 24, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Nov 24, 2017
@Mariatta Mariatta removed the CLA not signed label Nov 24, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 24, 2017
1a1a11a
1a1a11a commented Nov 24, 2017
View reviewed changes

@1a1a11a 1a1a11a left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@1a1a11a

1a1a11a commented Nov 26, 2017

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Nov 26, 2017
@bedevere-bot

bedevere-bot commented Nov 26, 2017

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jason
bpo-32051: Update multiprocessing doc
852e593 
Remove name conflict under "Using a remove manager" section
@1a1a11a 1a1a11a changed the title bpo-32051: update multiprocessing doc bpo-32051: update multiprocessing doc [skip news] Nov 27, 2017
@1a1a11a 1a1a11a changed the title bpo-32051: update multiprocessing doc [skip news] bpo-32051: update multiprocessing doc skip-news Nov 27, 2017
@1a1a11a 1a1a11a changed the title bpo-32051: update multiprocessing doc skip-news bpo-32051: update multiprocessing doc [skip-news] Nov 27, 2017
@1a1a11a

1a1a11a commented Nov 27, 2017

Copy link
Copy Markdown
Contributor Author

btw, how do I add skip news label?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag berkerpeksag added the skip news label Nov 27, 2017
@berkerpeksag berkerpeksag changed the title bpo-32051: update multiprocessing doc [skip-news] bpo-32051: update multiprocessing doc Nov 27, 2017
@berkerpeksag berkerpeksag added the needs backport to 3.6 label Nov 27, 2017
berkerpeksag
berkerpeksag approved these changes Nov 27, 2017
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Nov 27, 2017
@berkerpeksag
berkerpeksag merged commit c172fc5 into python:master Nov 27, 2017
@miss-islington

miss-islington commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

Thanks @1a1a11a for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 27, 2017
@bedevere-bot

bedevere-bot commented Nov 27, 2017

Copy link
Copy Markdown

GH-4577 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2017
@1a1a11a @miss-islington
bpo-32051: Fix name shadowing in multiprocessing docs (pythonGH-4469)
5b6cbf0 
(cherry picked from commit c172fc5)
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Nov 27, 2017
@berkerpeksag

berkerpeksag commented Nov 27, 2017

Copy link
Copy Markdown
Member

Thanks!

Labels can only be set by Python core developers or bots like bedevere.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag pushed a commit that referenced this pull request Nov 27, 2017
@miss-islington @berkerpeksag
bpo-32051: Fix name shadowing in multiprocessing docs (GH-4469)
8a95753 
(cherry picked from commit c172fc5)
@1a1a11a

1a1a11a commented Nov 27, 2017

Copy link
Copy Markdown
Contributor Author

thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@1a1a11a @the-knights-who-say-ni @bedevere-bot @miss-islington @berkerpeksag @Mariatta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.